-
Notifications
You must be signed in to change notification settings - Fork 224
RTBHouse: Extract tagid from Imp fields #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pjaworski-rtbh
wants to merge
5
commits into
prebid:master
Choose a base branch
from
lotani-rtbh:rtbhouse/tagid-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+254
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
CTMBNara
requested changes
Jan 5, 2026
src/main/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidder.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Jan 8, 2026
src/main/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidderTest.java
Outdated
Show resolved
Hide resolved
…ng readability; changed order of methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Related PR (Golang): prebid/prebid-server#4624
RTBHouse bidder was not setting
imp.tagidin outgoing requests, which could impact ad targeting effectiveness. This change adds support for populatingtagidfrom various incoming request fields with a defined priority order.📋 Description
Adds logic to set
imp.tagidin RTBHouse bid requests using fallback priority:imp.ext.gpid→imp.ext.data.adserver.adslot→imp.ext.data.pbadslot→imp.id→ null. This ensures better ad targeting by providing RTBHouse with appropriatetagidvalues.🧪 Testing results
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0All RTBHouse bidder tests pass successfully, including:
Other information
Please reach us at [email protected] with [email protected] and cc [email protected].