Skip to content

RTBHouse: Extract tagid from Imp fields #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjaworski-rtbh wants to merge 6 commits into
base: master
Choose a base branch
from
+394 −220
Open

RTBHouse: Extract tagid from Imp fields #4306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52c550f
RTBHouse: Extract tagid from Imp fields
pjaworski-rtbh Dec 2, 2025
bc4cb7a
RTBHouse: Preserve existing tagid in Imp when modifying requests
pjaworski-rtbh Dec 2, 2025
d30af84
RTBHouse: refactor tag ID extraction logic
pjaworski-rtbh Jan 5, 2026
8828c64
RTBHouse: refactor main tag ID extraction method to use Optional
pjaworski-rtbh Jan 7, 2026
d60dec3
RTBHouse: refactor tag id extraction logic for simplicity and improvi…
pjaworski-rtbh Jan 9, 2026
18bfa79
RTBHouse: reorganize tests order for clarity and maintainability
pjaworski-rtbh Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 115 additions & 79 deletions src/main/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,110 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ
return Result.withValue(BidderUtil.defaultRequest(outgoingRequest, endpointUrl, mapper));
}

private ExtImpRtbhouse parseImpExt(Imp imp) {
try {
return mapper.mapper().convertValue(imp.getExt(), RTBHOUSE_EXT_TYPE_REFERENCE).getBidder();
} catch (IllegalArgumentException e) {
throw new PreBidException(e.getMessage());
}
}

private Price resolveBidFloor(Imp imp, ExtImpRtbhouse impExt, BidRequest bidRequest) {
final List<String> brCur = bidRequest.getCur();
final Price initialBidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());

final BigDecimal impExtBidFloor = impExt.getBidFloor();
final String impExtCurrency = impExtBidFloor != null && brCur != null && !brCur.isEmpty()
? brCur.getFirst() : null;
final Price impExtBidFloorPrice = Price.of(impExtCurrency, impExtBidFloor);
final Price resolvedPrice = initialBidFloorPrice.getValue() == null
? impExtBidFloorPrice : initialBidFloorPrice;

return BidderUtil.isValidPrice(resolvedPrice)
&& !StringUtils.equalsIgnoreCase(resolvedPrice.getCurrency(), BIDDER_CURRENCY)
? convertBidFloor(resolvedPrice, imp.getId(), bidRequest)
: resolvedPrice;
}

private Price convertBidFloor(Price bidFloorPrice, String impId, BidRequest bidRequest) {
final String bidFloorCur = bidFloorPrice.getCurrency();
try {
final BigDecimal convertedPrice = currencyConversionService
.convertCurrency(bidFloorPrice.getValue(), bidRequest, bidFloorCur, BIDDER_CURRENCY);

return Price.of(BIDDER_CURRENCY, convertedPrice);
} catch (PreBidException e) {
throw new PreBidException(String.format(
"Unable to convert provided bid floor currency from %s to %s for imp `%s`",
bidFloorCur, BIDDER_CURRENCY, impId));
}
}

private static Imp modifyImp(Imp imp, Price bidFloorPrice) {
return imp.toBuilder()
.tagid(extractTagId(imp))
.bidfloorcur(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getCurrency))
.bidfloor(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getValue))
.pmp(null)
.build();
}

private static String extractTagId(Imp imp) {
return Optional.ofNullable(imp.getTagid())
.filter(StringUtils::isNotBlank)
.or(() -> extractGpid(imp))
.or(() -> extractAdslot(imp))
.or(() -> extractPbadslot(imp))
.or(() -> Optional.ofNullable(imp.getId())
.filter(StringUtils::isNotBlank))
.orElse(null);
}

private static Optional<String> extractGpid(Imp imp) {
return Optional.ofNullable(imp.getExt())
.map(ext -> ext.get("gpid"))
.map(JsonNode::textValue)
.filter(StringUtils::isNotBlank);
}

private static Optional<String> extractAdslot(Imp imp) {
return Optional.ofNullable(imp.getExt())
.map(ext -> ext.get("data"))
.map(data -> data.get("adserver"))
.map(adserver -> adserver.get("adslot"))
.map(JsonNode::textValue)
.filter(StringUtils::isNotBlank);
}

private static Optional<String> extractPbadslot(Imp imp) {
return Optional.ofNullable(imp.getExt())
.map(ext -> ext.get("data"))
.map(data -> data.get("pbadslot"))
.map(JsonNode::textValue)
.filter(StringUtils::isNotBlank);
}

private Site modifySite(Site site, String publisherId) {
final ObjectNode prebidNode = mapper.mapper().createObjectNode();
prebidNode.put("publisherId", publisherId);

final ExtPublisher extPublisher = ExtPublisher.empty();
extPublisher.addProperty("prebid", prebidNode);

final Publisher publisher = Optional.ofNullable(site)
.map(Site::getPublisher)
.map(Publisher::toBuilder)
.orElseGet(Publisher::builder)
.ext(extPublisher)
.build();

return Optional.ofNullable(site)
.map(Site::toBuilder)
.orElseGet(Site::builder)
.publisher(publisher)
.build();
}

@Override
public Result<List<BidderBid>> makeBids(BidderCall<BidRequest> httpCall, BidRequest bidRequest) {
try {
Expand Down Expand Up @@ -144,23 +248,6 @@ private BidderBid resolveBidderBid(Bid bid,
.build();
}

private String resolveNativeAdm(String adm, List<BidderError> bidderErrors) {
final JsonNode admNode;
try {
admNode = mapper.mapper().readTree(adm);
} catch (JsonProcessingException e) {
bidderErrors.add(BidderError.badServerResponse("Unable to parse native adm: %s".formatted(adm)));
return null;
}

final JsonNode nativeNode = admNode.get("native");
if (nativeNode != null) {
return nativeNode.toString();
}

return adm;
}

private static BidType getBidType(String impId, List<Imp> imps) {
for (Imp imp : imps) {
if (imp.getId().equals(impId)) {
Expand All @@ -176,51 +263,21 @@ private static BidType getBidType(String impId, List<Imp> imps) {
return BidType.banner;
}

private ExtImpRtbhouse parseImpExt(Imp imp) {
private String resolveNativeAdm(String adm, List<BidderError> bidderErrors) {
final JsonNode admNode;
try {
return mapper.mapper().convertValue(imp.getExt(), RTBHOUSE_EXT_TYPE_REFERENCE).getBidder();
} catch (IllegalArgumentException e) {
throw new PreBidException(e.getMessage());
admNode = mapper.mapper().readTree(adm);
} catch (JsonProcessingException e) {
bidderErrors.add(BidderError.badServerResponse("Unable to parse native adm: %s".formatted(adm)));
return null;
}
}

private static Imp modifyImp(Imp imp, Price bidFloorPrice) {
return imp.toBuilder()
.bidfloorcur(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getCurrency))
.bidfloor(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getValue))
.pmp(null)
.build();
}

private Price resolveBidFloor(Imp imp, ExtImpRtbhouse impExt, BidRequest bidRequest) {
final List<String> brCur = bidRequest.getCur();
final Price initialBidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());

final BigDecimal impExtBidFloor = impExt.getBidFloor();
final String impExtCurrency = impExtBidFloor != null && brCur != null && !brCur.isEmpty()
? brCur.getFirst() : null;
final Price impExtBidFloorPrice = Price.of(impExtCurrency, impExtBidFloor);
final Price resolvedPrice = initialBidFloorPrice.getValue() == null
? impExtBidFloorPrice : initialBidFloorPrice;

return BidderUtil.isValidPrice(resolvedPrice)
&& !StringUtils.equalsIgnoreCase(resolvedPrice.getCurrency(), BIDDER_CURRENCY)
? convertBidFloor(resolvedPrice, imp.getId(), bidRequest)
: resolvedPrice;
}

private Price convertBidFloor(Price bidFloorPrice, String impId, BidRequest bidRequest) {
final String bidFloorCur = bidFloorPrice.getCurrency();
try {
final BigDecimal convertedPrice = currencyConversionService
.convertCurrency(bidFloorPrice.getValue(), bidRequest, bidFloorCur, BIDDER_CURRENCY);

return Price.of(BIDDER_CURRENCY, convertedPrice);
} catch (PreBidException e) {
throw new PreBidException(String.format(
"Unable to convert provided bid floor currency from %s to %s for imp `%s`",
bidFloorCur, BIDDER_CURRENCY, impId));
final JsonNode nativeNode = admNode.get("native");
if (nativeNode != null) {
return nativeNode.toString();
}

return adm;
}

private static Bid resolveMacros(Bid bid) {
Expand All @@ -232,25 +289,4 @@ private static Bid resolveMacros(Bid bid) {
.adm(StringUtils.replace(bid.getAdm(), PRICE_MACRO, priceAsString))
.build();
}

private Site modifySite(Site site, String publisherId) {
final ObjectNode prebidNode = mapper.mapper().createObjectNode();
prebidNode.put("publisherId", publisherId);

final ExtPublisher extPublisher = ExtPublisher.empty();
extPublisher.addProperty("prebid", prebidNode);

final Publisher publisher = Optional.ofNullable(site)
.map(Site::getPublisher)
.map(Publisher::toBuilder)
.orElseGet(Publisher::builder)
.ext(extPublisher)
.build();

return Optional.ofNullable(site)
.map(Site::toBuilder)
.orElseGet(Site::builder)
.publisher(publisher)
.build();
}
}
Loading
Loading