Skip to content

Conversation

@apykhteyev
Copy link
Contributor

@apykhteyev apykhteyev commented Feb 13, 2025

@bsardo bsardo changed the title AdTarget.org adapter New Adapter: AdTarget.org - Limelight Alias Feb 13, 2025
@bsardo bsardo added the adapter label Feb 13, 2025
@bsardo
Copy link
Collaborator

bsardo commented Feb 25, 2025

@pm-shriprasad-marathe can you please review?

@bsardo bsardo self-assigned this Feb 25, 2025
@@ -0,0 +1,2 @@
endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apykhteyev : we should prefer secure http instead of http

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for s2s integration to use https? and actually all of our aliases were merged with HTTP before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apykhteyev : from docs - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
Bidding server endpoints should prefer secure HTTPS to protect user privacy and should allow keep alive connections (preferably with HTTP/2 support) to increase host performance.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While https is strongly preferred, http is still permitted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose a name according to our guidelines. Your name should be alphanumeric (no special characters).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg can you advise?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have to allow underscores server-side. The PBJS doc allows it and being in sync is preferred.

Would an underscore cause a technical problem @bsardo ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bretg @bsardo Could you please provide me guidelines what to do? I'm ok to rename here and on Prebid.js if needed, but we need to move forward asap, simple adding of alias is already 1.5 months in review

@@ -0,0 +1,2 @@
endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While https is strongly preferred, http is still permitted.

@@ -0,0 +1,2 @@
endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified endpoint is reachable:

curl -i --location --request POST http://ads-pbs.rtb.adtarget.org/openrtb/123?host=123
HTTP/1.1 204 No Content
content-type: application/json
permissions-policy: browsing-topics=()

@bsardo bsardo merged commit ed9ed1a into prebid:master Apr 7, 2025
4 checks passed
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jun 13, 2025
Co-authored-by: apykhteyev <alex@project-limelight.com>
prnvgupta pushed a commit to automatad/prebid-server that referenced this pull request Dec 3, 2025
Co-authored-by: apykhteyev <alex@project-limelight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants