-
Notifications
You must be signed in to change notification settings - Fork 858
New Adapter: AdTarget.org - Limelight Alias #4211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pm-shriprasad-marathe can you please review? |
| @@ -0,0 +1,2 @@ | |||
| endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apykhteyev : we should prefer secure http instead of http
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for s2s integration to use https? and actually all of our aliases were merged with HTTP before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apykhteyev : from docs - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
Bidding server endpoints should prefer secure HTTPS to protect user privacy and should allow keep alive connections (preferably with HTTP/2 support) to increase host performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While https is strongly preferred, http is still permitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please choose a name according to our guidelines. Your name should be alphanumeric (no special characters).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have same name for prebid.js adapter
Do you think we should change there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg can you advise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,2 @@ | |||
| endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While https is strongly preferred, http is still permitted.
| @@ -0,0 +1,2 @@ | |||
| endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified endpoint is reachable:
curl -i --location --request POST http://ads-pbs.rtb.adtarget.org/openrtb/123?host=123
HTTP/1.1 204 No Content
content-type: application/json
permissions-policy: browsing-topics=()
Co-authored-by: apykhteyev <alex@project-limelight.com>
Co-authored-by: apykhteyev <alex@project-limelight.com>
prebid/prebid.github.io#5880