Skip to content

New Adapter: AdTarget.org - Limelight Alias #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsardo merged 3 commits into from
Apr 7, 2025
Merged

New Adapter: AdTarget.org - Limelight Alias #4211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d7aa1c
Add Embi media adapter
Nov 28, 2023
8f1dfad
AdTarget.org adapter: Limelight alias
Feb 13, 2025
6511cc2
AdTarget.org adapter: Limelight alias
Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/bidder-info/adtg_org.yaml
View file
Open in desktop
Copy link
Collaborator

@bsardo bsardo Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose a name according to our guidelines. Your name should be alphanumeric (no special characters).

Copy link
Contributor Author

@apykhteyev apykhteyev Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have same name for prebid.js adapter

https://github.com/prebid/Prebid.js/pull/12756/files#diff-8fbb6a0646505ff4e28796bb9a8c0f746b3f4aff348d131983596bdd95857633R35

Do you think we should change there?

Copy link
Collaborator

@bsardo bsardo Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg can you advise?

Copy link
Contributor

@bretg bretg Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have to allow underscores server-side. The PBJS doc allows it and being in sync is preferred.

Would an underscore cause a technical problem @bsardo ?

Copy link
Contributor Author

@apykhteyev apykhteyev Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bretg @bsardo Could you please provide me guidelines what to do? I'm ok to rename here and on Prebid.js if needed, but we need to move forward asap, simple adding of alias is already 1.5 months in review

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
endpoint: "http://ads-pbs.rtb.adtarget.org/openrtb/{{.PublisherID}}?host={{.Host}}"
Copy link
Contributor

@ShriprasadM ShriprasadM Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apykhteyev : we should prefer secure http instead of http

Copy link
Contributor Author

@apykhteyev apykhteyev Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for s2s integration to use https? and actually all of our aliases were merged with HTTP before

Copy link
Contributor

@ShriprasadM ShriprasadM Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apykhteyev : from docs - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
Bidding server endpoints should prefer secure HTTPS to protect user privacy and should allow keep alive connections (preferably with HTTP/2 support) to increase host performance.

Copy link
Collaborator

@bsardo bsardo Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While https is strongly preferred, http is still permitted.

Copy link
Collaborator

@bsardo bsardo Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified endpoint is reachable:

curl -i --location --request POST http://ads-pbs.rtb.adtarget.org/openrtb/123?host=123
HTTP/1.1 204 No Content
content-type: application/json
permissions-policy: browsing-topics=()

aliasOf: "limelightDigital"
Loading