fix: some misc backend issues #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ended up setting license-file to none until we get something like this in: prefix-dev/rattler-build#1947 we won't really be able to handle this correct for out-of-tree builds. We should think of a solution though :) |
- Modified license_file() method to return None with TODO comment - Updated test assertions to expect None instead of filename - Removed broken license_file tests - Updated snapshots to reflect missing license_file field
ruben-arts
reviewed
Oct 20, 2025
ruben-arts
reviewed
Oct 20, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
Only a question about the validation alias for debug-dir. Rest looks good.
The RustBackendConfig struct uses #[serde(rename_all = "kebab-case")], which means it already only accepts debug-dir (with hyphen), not debug_dir (with underscore). This test documents and verifies this behavior.
All backend configurations now accept both kebab-case (debug-dir) and snake_case (debug_dir) for the debug_dir field using serde's alias attribute. This provides better flexibility for users who may be familiar with either naming convention. Changes: - Added #[serde(alias = "debug_dir")] to debug_dir fields in: - RustBackendConfig - PythonBackendConfig - CMakeBackendConfig - MojoBackendConfig - RattlerBuildBackendConfig - TestBackendConfig - Updated PyBackendConfig custom deserializer to check for both formats - Updated test to verify both formats are accepted
Contributor
Author
|
@ruben-arts we should allow both now :) |
ruben-arts
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the misc backend issues:
debug-diranddebug_dirwere mixed up,debug-diris used by this backend anddebug_diris used by pixi. I want to change pixi to allow for both as well.