Feature/161 알림 읽음 처리 #170
Merged
Feature/161 알림 읽음 처리 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
7zrv
reviewed
Dec 6, 2024
src/main/java/com/somemore/notification/controller/NotificationCommandController.java
Outdated
Show resolved
Hide resolved
7zrv
reviewed
Dec 6, 2024
| @Secured({"ROLE_VOLUNTEER", "ROLE_CENTER"}) | ||
| @Operation(summary = "알림(N개) 읽음 처리", description = "알림 N개를 읽음 처리합니다.") | ||
| @PostMapping("/read/multiple") | ||
| public ApiResponse<String> markMultipleNotifications( |
Collaborator
There was a problem hiding this comment.
프론트에서는 어떤식으로 처리가 되는건가요 한개와 N개의 호출을 어떻게 하는건지 궁금합니다
Collaborator
Author
There was a problem hiding this comment.
- 모두 읽음 처리
- 프론트에서 lazy한 알림 읽음 처리 요청
- 체크박스를 통한 알림 읽음 처리
위 3가지 모두 프론트엔드에서 이뤄지는 로직입니다.
7zrv
reviewed
Dec 6, 2024
| notifications.forEach(notification -> | ||
| validateNotificationOwnership(userId, notification.getReceiverId())); | ||
|
|
||
| notifications.forEach(Notification::markAsRead); |
Collaborator
There was a problem hiding this comment.
리스트를 업데이트 해줬을때 트랜잭션 종료시 save로 저장이 되는건지 saveAll로 되는건지 궁금합니다
혹시 전자라면 saveAll을 명시해주는것도 좋을것 같아요
Collaborator
Author
There was a problem hiding this comment.
성능 관점에서 saveAll이 좋을 것 같습니다. 더티체킹을 적극 활용하고 싶어서 의도적으로 save를 명시하지 않았습니다.
7zrv
reviewed
Dec 6, 2024
|
|
||
| for (int i = 0; i < 10; i++) { | ||
| for (long i = 1; i <= 10; i++) { | ||
| Notification unreadNotification = Notification.builder() |
7zrv
reviewed
Dec 6, 2024
|
|
||
| // then | ||
| assertThat(notifications).isEmpty(); | ||
| assertThat(notifications).hasSize(10); |
Collaborator
There was a problem hiding this comment.
빈 리스트를 반환하는데 hasSize가 10인 이유가 궁금합니다
Collaborator
Author
There was a problem hiding this comment.
beforeEach 때문에 설정해두고 까먹었네요 deleteAllInBatch로 테스트 가독성 확보하겠습니다!
m-a-king
force-pushed
the
feature/161-add-mark-read-notification
branch
from
c9a866d to
1b6b5c7
Compare
7zrv
approved these changes
Dec 6, 2024
- 1건, N건. - 쪽지 수신자와 읽음 요청 유저 아이디 검증 추가.
m-a-king
force-pushed
the
feature/161-add-mark-read-notification
branch
from
1b6b5c7 to
90d662b
Compare
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
|
m-a-king
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
알림 읽음 처리
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점