refactor: 댓글, 리뷰 리펙토링 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ji-minhyeok
approved these changes
Jul 28, 2025
| @GetMapping("/{lessonId}") | ||
| @Operation(summary = "댓글 조회", description = "레슨 ID에 해당되는 댓글들을 조회합니다.") | ||
| public ResponseEntity<PagedResponse<CommentPageWrapperDto>> readAll(@PathVariable Long lessonId, | ||
| public ResponseEntity<PagedResponse<List<CommentResponseDto>>> readAll(@PathVariable Long lessonId, |
Collaborator
There was a problem hiding this comment.
Wrapper가 없을때 Json Response 형태는 기존과 동일하게 찍히는지 궁금합니다!
Collaborator
Author
There was a problem hiding this comment.
test 코드 실행시 Body = {"status":200,"message":"댓글 조회 성공","data":[{"commentId":1,"userId":1,"content":"댓글1","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.119127"},{"commentId":2,"userId":2,"content":"대댓글1","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.218364"},{"commentId":3,"userId":2,"content":"대댓글2","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.2414"}],"count":16}
와 같이 응답 받아오는 것 확인했습니다!
Collaborator
|
한번 더 확인완료했습니다!!! 수고하셨습니당~👍 |
Ji-minhyeok
reviewed
Jul 29, 2025
Collaborator
Ji-minhyeok
left a comment
Ji-minhyeok
left a comment
There was a problem hiding this comment.
N+1 문제는 미처 생각하지 못했네요. 추후 리팩토링에도 참고해서 다른 도메인에도 적용해보도록 하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 작업 내용
댓글, 리뷰 dto -> record 클래스로 수정 및 테스트 코드 수정
현재 limit와 offset, nativeQuery를 사용 통해 성능 개선을 진행하고 있어서 fetch join을 못쓴다는 문제가 있었습니다.
그에 따라 n+1문제를 해결하기 위해
위와 같이 2개의 쿼리로 나눠서 이를 해결하는 방안으로 진행했습니다.
그외에 comment, review의 경우에는 fetch join과 인터페이스 프로젝션 통해서 진행했습니다
✅ PR 유형
✅ Check List
🔗 관련 이슈
💬 기타 참고 사항