-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: 댓글, 리뷰 리펙토링 #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a28e980
refactor: 컨트롤러 코드 수정
ense333 6b147e1
feat: dto -> record 클래스로 변경
ense333 716795f
refactor: 서비스, 매퍼 수정
ense333 9615728
refactor: dto -> record로 수정 및 그에 따른 서비스, 컨트롤러, 매퍼 변환
ense333 d03720d
refactor: record로 수정함에 따른 테스트 코드 수정
ense333 c385b5d
feat: 서비스 분리
ense333 2287b16
Merge remote-tracking branch 'origin/develop' into refactor/#62/code-…
ense333 348d8db
feat: comment 관련 n+1 문제 -> 인터페이스 프로젝션 통해 해결
ense333 bfc28fe
feat: review n+1 문제 fetch join 통해 해결
ense333 516ecff
feat: comment 관련 테스트 코드 수정
ense333 aa7c8b0
feat: 결제 관련 메서드 추가
ense333 f51d85e
feat: mapper 분리 통해 코드 재구성
ense333 c57fba9
feat: 결제 관련 N+1 문제 해결 -> fetch join
ense333 8825ba8
feat: refund 관련 공통 메서드 생성
ense333 1e83ea3
Merge remote-tracking branch 'origin/develop' into refactor/#62/code-…
ense333 6a2d87a
feat: 타임존 관련 추가
ense333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
src/main/java/com/threestar/trainus/domain/comment/dto/CommentPageWrapperDto.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/main/java/com/threestar/trainus/domain/comment/dto/CommentWithUserProjection.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.threestar.trainus.domain.comment.dto; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| public interface CommentWithUserProjection { | ||
| Long getCommentId(); | ||
|
|
||
| String getContent(); | ||
|
|
||
| Long getParentCommentId(); | ||
|
|
||
| Boolean getDeleted(); | ||
|
|
||
| LocalDateTime getCreatedAt(); | ||
|
|
||
| Long getUserId(); | ||
|
|
||
| String getNickname(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapper가 없을때 Json Response 형태는 기존과 동일하게 찍히는지 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test 코드 실행시 Body = {"status":200,"message":"댓글 조회 성공","data":[{"commentId":1,"userId":1,"content":"댓글1","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.119127"},{"commentId":2,"userId":2,"content":"대댓글1","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.218364"},{"commentId":3,"userId":2,"content":"대댓글2","parentCommentId":1,"deleted":false,"createdAt":"2025-07-29T09:15:16.2414"}],"count":16}
와 같이 응답 받아오는 것 확인했습니다!