Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 5, 2025

Part of #2781

What are you trying to accomplish?

Sass is deprecating @import https://sass-lang.com/documentation/breaking-changes/import/

This PR changes @import calls to @use or @forward based on use.

What approach did you choose and why?

Manually migrated

What should reviewers focus on?

I'll need to integrate test this change

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 21d1a2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the base branch from main to remove_pvc_imports February 5, 2025 00:18
Base automatically changed from remove_pvc_imports to main February 5, 2025 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Apr 6, 2025
@github-actions github-actions bot closed this Apr 13, 2025
@github-actions github-actions bot deleted the move_to_use branch April 13, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major release Stale Automatically marked as stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants