feat: mobile app migration#58
Merged
0xVikasRushi merged 10 commits intoprivacy-ethereum:mainfrom Feb 2, 2026
Merged
Conversation
- Replace hardcoded paths and current_dir() calls with a configurable PathConfig struct to support both development and mobile environments. - Move key/artifact path constants to paths module.
Collaborator
Author
|
@0xVikasRushi would love to get your review.
|
Collaborator
Regarding the benchmark, were both done on an emulator or a real device? |
Collaborator
Author
Both are done on real devices |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the mobile app https://github.com/moven0831/zkID-mobile-wallet-poc to https://github.com/privacy-ethereum/zkID.
Some critical changes listed as below:
ecdsa-spartan2implementation (519e4de)Related Issue(s)
Timing Measurements (Mobile)
All timing measurements are in milliseconds (ms).
Test Device:
Prepare Circuit Timing
Show Circuit Timing
The Show circuit has constant performance regardless of JWT payload size.
Checklist