Skip to content

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Aug 5, 2025

No description provided.

@bugadani bugadani force-pushed the update branch 2 times, most recently from 43ba1d4 to c8a50ed Compare August 5, 2025 10:46
@bugadani
Copy link
Contributor Author

bugadani commented Aug 5, 2025

Oh hey, we can't update embassy-executor in embedded-test, because we can't update esp-hal-embassy, because we can't update embedded-test 🙃

@bugadani bugadani force-pushed the update branch 2 times, most recently from b6563e0 to 3a14d2e Compare August 5, 2025 11:24
@bugadani
Copy link
Contributor Author

bugadani commented Aug 5, 2025

Fun cross-patching to the rescue, although the embedded-test example will need an update once esp-hal is out.

@t-moe
Copy link
Contributor

t-moe commented Aug 5, 2025

Thanks a lot.
do you want me to release this as embedded_test 0.7.0, without #67 ?

@bugadani
Copy link
Contributor Author

bugadani commented Aug 5, 2025

I'd prefer finding out what's wrong

@t-moe
Copy link
Contributor

t-moe commented Aug 20, 2025

I've cherry-picked this onto the next branch, and released it as 0.7.0-alpha.2.

also, #69 is resolved. (not adding INSERT anymore, unless we're on std)

Can you retry esp-rs/esp-hal#3889 with 0.7.0-alpha.2 ?

@bugadani bugadani force-pushed the update branch 2 times, most recently from abddb4e to 5a1001d Compare August 27, 2025 17:34
@bugadani
Copy link
Contributor Author

bugadani commented Aug 27, 2025

So, this seems to be working now, which is great. ESP example needs to be pointing at the esp-hal side PR until that is merged, but that can't be merged until we can actually use embedded-test 0.7.

Either way, how could we avoid this dance every time a new embassy-executor drops?

(New update PR is esp-rs/esp-hal#3945 )

@bugadani bugadani marked this pull request as ready for review August 27, 2025 17:47
@t-moe
Copy link
Contributor

t-moe commented Aug 29, 2025

I've released embedded-test v0.7.0-alpha.3 that uses embassy-executor 0.9.

And I will follow up with some ideas on how to avoid this dance in the future..

@bugadani
Copy link
Contributor Author

Thanks, I've redirected my esp-hal PR to use the released version instead of this branch.

@bugadani bugadani closed this Aug 29, 2025
@bugadani bugadani deleted the update branch August 29, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants