Skip to content

Convert Overlay to a function component, shares logic with Modal #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 29, 2023
Merged

Convert Overlay to a function component, shares logic with Modal #2309

merged 9 commits into from
Nov 29, 2023

Conversation

lindapaiste
Copy link
Collaborator

@lindapaiste lindapaiste commented Jul 16, 2023 •
edited
Loading

Changes:

  • Convert Overlay from a class component to a function component.
  • Move the logic for "close on outside click"/"close on Esc" into a reusable hook useModalClose.
  • Use the useModalClose hook in components Modal, NavBar, ShareURL, and Overlay instead of repeating similar code.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

This was referenced Aug 7, 2023
Closed
Closed
@lindapaiste lindapaiste mentioned this pull request Aug 14, 2023
Merged
4 tasks
@lindapaiste
Merge remote-tracking branch 'upstream/develop' into refactor/overlay
a6d1175 
# Conflicts:
#	client/components/Nav/NavBar.jsx
#	client/modules/App/components/Overlay.jsx
#	client/modules/IDE/pages/IDEView.jsx
@lindapaiste lindapaiste mentioned this pull request Nov 13, 2023
Closed
4 tasks
@lindapaiste
Merge remote-tracking branch 'upstream/develop' into refactor/overlay
97c09d9 
# Conflicts:
#	client/modules/User/components/Collection.jsx
@lindapaiste lindapaiste added this to the MINOR Release for 2.10.0 milestone Nov 24, 2023
@raclim raclim mentioned this pull request Nov 29, 2023
Closed
4 tasks
raclim
raclim approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great to me! Thanks for working on this!

@raclim raclim merged commit f725abd into processing:develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Code Cleanup
Status: Done

Milestone

PATCH Release for 2.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@lindapaiste @raclim