Skip to content

Common dropdown component for tables #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 30, 2023
Merged

Common dropdown component for tables #2379

merged 13 commits into from
Nov 30, 2023

Conversation

lindapaiste
Copy link
Collaborator

Progress on Table refactoring (#2358)
Merge after #2309 because I used the same click-outside logic defined in that PR

Changes:

  • Remove a lot of repetitive onFocus and onBlur logic from __TableRow components by using a common TableDropdown component.

Will edit with more details later.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Aug 16, 2023
Closed
4 tasks
@lindapaiste
add setTimeout to close
3980be0
@lindapaiste
Common dropdown component for table actions.
c7bf38e
@lindapaiste
add setTimeout to close
4ffbb42
@lindapaiste
Apply new responsive styles
c9cca4a
@lindapaiste
Merge remote-tracking branch 'origin/refactor/dropdown' into refactor…
68980b4 
…/dropdown

# Conflicts:
#	client/components/Dropdown/DropdownMenu.jsx
#	client/components/Dropdown/TableDropdown.jsx
#	client/modules/IDE/components/CollectionList/CollectionListRow.jsx
#	client/modules/IDE/components/__snapshots__/SketchList.unit.test.jsx.snap
@lindapaiste lindapaiste mentioned this pull request Nov 13, 2023
Closed
4 tasks
@lindapaiste lindapaiste added this to the MINOR Release for 2.10.0 milestone Nov 24, 2023
@lindapaiste lindapaiste mentioned this pull request Nov 25, 2023
Closed
4 tasks
@raclim raclim merged commit f2a5eb2 into processing:develop Nov 30, 2023
@raclim raclim mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Code Cleanup
Status: Done

Milestone

PATCH Release for 2.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@lindapaiste @raclim