fix: About page uses theme background and text colors (fixes white bottom half in dark/high-contrast mode) #3563 #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2025 21:04
… styled-component imports
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
poojanjariwala
changed the title
|
@raclim Please review this PR. Thank You! |
yugalkaushik
reviewed
Aug 5, 2025
client/modules/About/About.styles.js
Outdated
| @@ -70,62 +95,79 @@ export const IntroHeadline = styled.div` | |||
| } | |||
| `; | |||
|
|
|||
| // 5. Intro Description | |||
There was a problem hiding this comment.
Remove these comments to maintain consistency with the overall code.
There was a problem hiding this comment.
ok @yugalkaushik sir I have removed comment and running test locally. will update PR soon.
There was a problem hiding this comment.
@yugalkaushik sir, I have done everything now please review my PR and merge it if everything goes well.
There was a problem hiding this comment.
You don't need to address me with Sir. I'm just a contributor.
added 3 commits
August 5, 2025 19:16
|
@raclim can you please review my PR and merge if it's correct ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3563
Changes:
I also solved the problem of the bottom half of the About page always having a white background, hence text difficult to read in dark and high-contrast themes.
Through the introduction of a global style that defines the background and text color for the whole page, the About page now correctly honors the chosen theme from top to bottom. This translates to improved readability and uniform appearance in all themes.
I also tidied up the imports and made sure everything employs the proper paths so that the styling is smooth.
refer to this image
@raclim
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123