Skip to content

fix: About page uses theme background and text colors (fixes white bottom half in dark/high-contrast mode) #3563 #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix: About page uses theme background and text colors (fixes white bottom half in dark/high-contrast mode) #3563 #3571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aacce0d
fix: full-page dark/high-contrast background and correct imports for …
Aug 4, 2025
4b20ddd
fix(About): apply full-page dark/high-contrast background and correct…
Aug 4, 2025
cb74c95
Removed comment
Aug 5, 2025
116a5d2
Fixed issues
Aug 5, 2025
c12f94c
Fixed issues
Aug 5, 2025
5655e70
Merge branch 'develop' into fix/about-page-background
raclim Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions client/modules/About/About.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
import styled from 'styled-components';
import styled, { createGlobalStyle } from 'styled-components';
import { remSize, prop } from '../../theme';

export const GlobalStyle = createGlobalStyle`
html, body, #root {
background-color: ${prop('backgroundColor')};
color: ${prop('primaryTextColor')};
min-height: 100vh;
width: 100vw;
margin: 0;
padding: 0;
transition: background-color 0.3s, color 0.3s;
font-family: inherit;
}
`;

export const AboutPageContent = styled.div`
margin: ${remSize(42)} ${remSize(295)};
color: ${prop('primaryTextColor')};
background-color: ${prop('backgroundColor')};

@media (max-width: 1279px) {
margin: ${remSize(20)};
Expand All @@ -16,6 +31,7 @@ export const Intro = styled.div`
& h1 {
font-size: ${remSize(32)};
font-weight: 700;
color: ${prop('primaryTextColor')};
}

& a {
Expand All @@ -26,6 +42,8 @@ export const Intro = styled.div`
align-items: center;
width: ${remSize(110)};
justify-content: space-evenly;
color: ${prop('primaryTextColor')};
text-decoration: none;

&:hover {
color: ${prop('Button.primary.default.background')};
Expand All @@ -52,6 +70,7 @@ export const IntroHeadline = styled.div`
font-weight: 550;
font-size: ${remSize(24)};
margin: ${remSize(24)};
color: ${prop('primaryTextColor')};
}

& svg {
Expand All @@ -74,9 +93,11 @@ export const IntroDescription = styled.div`
line-height: ${remSize(27)};
font-size: ${remSize(16)};
margin: ${remSize(24)} 0;
color: ${prop('primaryTextColor')};

p {
margin-bottom: ${remSize(24)};
color: ${prop('primaryTextColor')};
}
`;

Expand All @@ -87,6 +108,7 @@ export const Section = styled.div`
font-size: ${remSize(24)};
padding-bottom: ${remSize(30)};
font-weight: 600;
color: ${prop('primaryTextColor')};
}

@media (max-width: 769px) {
Expand Down Expand Up @@ -116,16 +138,19 @@ export const SectionItem = styled.div`

& p {
margin-top: ${remSize(7)};
color: ${prop('primaryTextColor')};
}

& a {
font-weight: 700;
font-size: ${remSize(16)};
text-decoration: underline;
color: ${prop('primaryTextColor')};

&:hover {
text-decoration: underline;
text-decoration-thickness: 0.1em;
color: ${prop('Button.primary.hover.background')};
}
}

Expand Down Expand Up @@ -155,6 +180,7 @@ export const Contact = styled.div`
& h2 {
font-size: ${remSize(24)};
font-weight: 600;
color: ${prop('primaryTextColor')};
}

& div {
Expand All @@ -167,6 +193,7 @@ export const Contact = styled.div`

export const ContactTitle = styled.p`
width: 50%;
color: ${prop('primaryTextColor')};

@media (max-width: 769px) {
width: 30%;
Expand All @@ -175,13 +202,15 @@ export const ContactTitle = styled.p`

export const ContactHandles = styled.p`
width: 50%;
color: ${prop('primaryTextColor')};

& a {
color: ${prop('logoColor')};
text-decoration: underline;

&:hover {
text-decoration: underline;
color: ${prop('Button.primary.hover.background')};
}
}

Expand All @@ -191,7 +220,7 @@ export const ContactHandles = styled.p`
`;

export const Footer = styled.div`
border-top: 0.1rem dashed;
border-top: 0.1rem dashed ${prop('primaryTextColor')};
padding: 0 ${remSize(20)} ${remSize(70)} 0;
width: 100%;
font-size: ${remSize(16)};
Expand All @@ -210,11 +239,13 @@ export const Footer = styled.div`
&:hover {
text-decoration: underline;
text-decoration-thickness: 0.1em;
color: ${prop('Button.primary.hover.background')};
}
}

& p {
padding: ${remSize(20)} 9.5% 0 0;
color: ${prop('primaryTextColor')};
}

@media (max-width: 770px) {
Expand Down
4 changes: 3 additions & 1 deletion client/modules/About/pages/About.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useTranslation } from 'react-i18next';
import { Link } from 'react-router-dom';

import {
GlobalStyle,
AboutPageContent,
Intro,
IntroHeadline,
Expand Down Expand Up @@ -57,8 +58,9 @@ const About = () => {

return (
<RootPage>
<GlobalStyle />
<Helmet>
<title> {t('About.TitleHelmet')} </title>
<title>{t('About.TitleHelmet')}</title>
</Helmet>

<Nav layout="dashboard" />
Expand Down