Add missing translations for tutorial section headings #931
Conversation
|
Hiii! @ksen0 just wanted to kindly ask if you could take a look at my pull request , It took me quite a while to go through each of the missing translations across all four languages (Hindi, Spanish, Korean, and Simplified Chinese), and make sure everything is rendering correctly. Would really appreciate your feedback or review whenever you have time. Thanks a lot! |
|
Thanks for putting this together @Homaid ! To merge this one, it would be great to get at least one review of each of the languages. I'm tagging below the i18n stewards and the volunteers from processing/p5.js-web-editor#3578 - if you have time, please review the content of each of the languages carefully, and provide suggestions for improvement - or confirm that the translations work well for the website! Korean - @jungmokyi Thanks in advance, everyone. |
| webgl: "WebGL" | ||
| "advanced": "高级主题" | ||
| criticalAI: " 批判性人工智能" | ||
| webgl: "网页图形库" |
There was a problem hiding this comment.
In Chinese we don't translate proper nouns such as library names, so I’d like to keep it as WebGL.
| introduction: "p5.js का परिचय" | ||
| drawing: "चित्रण" | ||
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" |
There was a problem hiding this comment.
Please use "अभिगम्यता" here
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" | ||
| criticalAI: "क्रिटिकल AI" | ||
| webgl: "वेबग्ल" |
There was a problem hiding this comment.
we should do "वेबजीएल" instead of "वेबग्ल".
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" | ||
| criticalAI: "क्रिटिकल AI" | ||
| webgl: "वेबग्ल" |
There was a problem hiding this comment.
| webgl: "वेबग्ल" | |
| webgl: "वेबजीएल" |
| introduction: "p5.js का परिचय" | ||
| drawing: "चित्रण" | ||
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" |
There was a problem hiding this comment.
| accessibility: "सुलभता" | |
| accessibility: "अभिगम्यता" |
| @@ -97,10 +97,11 @@ tutorialCategories: | |||
| drawing: "绘图" | |||
| "web-design": "网页设计" | |||
| accessibility: "无障碍" | |||
| webgl: "WebGL" | |||
| "advanced": "高级主题" | |||
| criticalAI: " 批判性人工智能" | |||
There was a problem hiding this comment.
| criticalAI: " 批判性人工智能" | |
| criticalAI: "批判性人工智能" |
There was a problem hiding this comment.
Just a quick heads up -> noticed the inconsistency while reviewing; in the translation keys across the YAML files:
"web-design": has quotes
education-resources: missing quotes
"advanced": has quotes
Should we standardize this? since keys with hyphens usually need quotes.
Summary
This PR adds missing
tutorialCategoriestranslations to the following UI locale files:hi.yaml(Hindi)es.yaml(Spanish)ko.yaml(Korean)zh-Hans.yaml(Chinese)Details
The following keys were missing and have now been added:
webglweb-desgindrawingaccessibilityadvanced-topicscriticalAIeducation-resourcesThis fixes the issue where some tutorial section headers were still appearing in English instead of the selected language.
Related Issue
Closes #930
Testing
Tested locally by switching the site language to all four and verifying that all tutorial section headers are now properly translated.
Let me know if anything else needs to be adjusted. Thanks!