Skip to content

Add missing translations for tutorial section headings #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add missing translations for tutorial section headings #931

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42b69c7
Add Hindi, Spanish, Korean translations for tutorial section headings
Kakashi786 Aug 4, 2025
a057c3b
Merge branch 'main' into fix-i18n-translations
ksen0 Aug 11, 2025
01f8f36
Fix words based on review comments
Kakashi786 Aug 13, 2025
12bac5f
Merge branch 'fix-i18n-translations' of https://github.com/Homaid/p5.…
Kakashi786 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/content/ui/es.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Related Examples: Ejemplos Relacionados
Show Code: Mostrar el código
Donate to p5.js: Dona a p5.js
Download p5.js: Descarga p5.js

briefPageDescriptions:
Reference: Encuentra explicaciones sencillas para cada pieza de código de p5.js.
Examples: Explora las posibilidades de p5.js con ejemplos cortos.
Expand All @@ -48,8 +49,10 @@ briefPageDescriptions:
Libraries: Expande las posibilidades de p5.js con bibliotecas creadas por la comunidad.
About: Aprende acerca de la misión, valores y personas detrás de p5.js.
People: Conoce al equipo de p5.js.

exampleCategories:
Featured: Destacado

referenceCategories:
modules:
Math: Matemáticas
Expand All @@ -76,3 +79,14 @@ referenceCategories:
Loading & Displaying: Cargando y Mostrando
Noise: Ruido
Random: Aleatorio

tutorialCategories:
introduction: "Introducción a p5.js"
drawing: "Dibujo"
web-design: "Diseño web"
accessibility: "Accesibilidad"
criticalAI: "IA crítica"
webgl: "WebGL"
advanced: "Temas avanzados"
education-resources: "Recursos educativos"

19 changes: 18 additions & 1 deletion src/content/ui/hi.yaml
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick heads up -> noticed the inconsistency while reviewing; in the translation keys across the YAML files:

"web-design": has quotes
education-resources: missing quotes
"advanced": has quotes

Should we standardize this? since keys with hyphens usually need quotes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @adi-ray I noticed the mix too some keys are quoted, some are not. I kept the same style as the original files I edited to avoid unrelated changes

Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Related Examples: संबंधित उदाहरण
Show Code: कोड दिखाएं
Donate to p5.js: p5.js को दान करें
Download p5.js: p5.js डाउनलोड करें

briefPageDescriptions:
Reference: p5.js कोड के प्रत्येक भाग के लिए आसान व्याख्या ढूंढें।
Examples: p5.js की संभावनाओं का पता लगाएं छोटे उदाहरणों के साथ।
Expand All @@ -48,6 +49,10 @@ briefPageDescriptions:
Libraries: p5.js की संभावनाओं का विस्तार करें समुदाय द्वारा बनाई गई लाइब्रेरीज़ के साथ।
About: p5.js के पीछे मिशन, मूल्यों और लोगों के बारे में जानें।
People: p5.js टीम को जानें।

exampleCategories:
Featured: प्रमुख

referenceCategories:
modules:
Typography: टाइपोग्राफी
Expand All @@ -64,7 +69,7 @@ referenceCategories:
Trigonometry: त्रिकोणमिति
Creating & Reading: बनाना और पढ़ना
2D Primitives: 2D आदिम
Setting: स्थिरांक
Setting: सेटिंग
DOM: डोम
Constants: स्थिरांक
Pixels: पिक्सल
Expand All @@ -74,3 +79,15 @@ referenceCategories:
Attributes: गुण
Noise: नॉइज़
Random: यादृच्छिक


tutorialCategories:
introduction: "p5.js का परिचय"
drawing: "चित्रण"
web-design: "वेब डिज़ाइन"
accessibility: "सुलभता"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
accessibility: "सुलभता"
accessibility: "अभिगम्यता"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "अभिगम्यता" here

criticalAI: "क्रिटिकल AI"
webgl: "वेबग्ल"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
webgl: "वेबग्ल"
webgl: "वेबजीएल"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do "वेबजीएल" instead of "वेबग्ल".

advanced: "उन्नत विषय"
education-resources: "शैक्षिक संसाधन"

12 changes: 12 additions & 0 deletions src/content/ui/ko.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,15 @@ referenceCategories:
Loading & Displaying: 불러오기 & 보이기
Noise: 노이즈
Random: 랜덤


tutorialCategories:
introduction: "p5.js 소개"
drawing: "드로잉"
web-design: "웹 디자인"
accessibility: "접근성"
criticalAI: "비판적 AI"
webgl: "웹글"
advanced: "고급 주제"
education-resources: "교육 자료"

7 changes: 4 additions & 3 deletions src/content/ui/zh-Hans.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,11 @@ tutorialCategories:
drawing: "绘图"
"web-design": "网页设计"
accessibility: "无障碍"
webgl: "WebGL"
"advanced": "高级主题"
criticalAI: " 批判性人工智能"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
criticalAI: " 批判性人工智能"
criticalAI: "批判性人工智能"

webgl: "网页图形库"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chinese we don't translate proper nouns such as library names, so I’d like to keep it as WebGL.

advanced: "高级主题"
education-resources: "教育资源"
tutorialsPage:
education-resources: 教育资源
education-resources-snippet: "每个教学经验都有其独特的目标、信息、条件和环境。通过记录和分享 p5.js 教育资源，如工作坊和课程，我们旨在更好地连接全球的 p5.js 学习者和教育者社区。"
view-education-resources: 查看教育资源
exampleCategories:
Expand Down
6 changes: 3 additions & 3 deletions src/layouts/TutorialsLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const pageJumpToLinks = categories
.concat([
{
url: "#education-resources",
label: t("tutorialsPage", "education-resources"),
label: t("tutorialCategories", "education-resources"), // ✅ changed from tutorialsPage
},
]);

Expand Down Expand Up @@ -63,10 +63,10 @@ setJumpToState({
</section>
))
}

<section>
<h2 class="mb-gutter-md mt-0">
{t("tutorialsPage", "education-resources")}<a id="education-resources"
></a>
{t("tutorialCategories", "education-resources")}<a id="education-resources"></a> <!-- ✅ changed from tutorialsPage -->
</h2>
<p>{t("tutorialsPage", "education-resources-snippet")}</p>
<LinkButton url="/education-resources" variant="link" class="mt-lg">
Expand Down