[Chef] Enable Pw access for more attributes#43561
Open
sxb427 wants to merge 4 commits intoproject-chip:masterfrom
Open
[Chef] Enable Pw access for more attributes#43561sxb427 wants to merge 4 commits intoproject-chip:masterfrom
sxb427 wants to merge 4 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends Pigweed (Pw) access to attributes in several clusters: Temperature Measurement, Illuminance Measurement, and Occupancy Sensing. The changes are generally good, but there is significant code duplication in the handlers for MinMeasuredValue and MaxMeasuredValue in both the Temperature Measurement and Illuminance Measurement clusters. My review includes suggestions to refactor these handlers to improve conciseness and maintainability, aligning with the project's style guide and the rule to extract common logic from similar methods.
|
PR #43561: Size comparison from 2c98999 to 93b61b3 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43561 +/- ##
==========================================
+ Coverage 54.07% 54.12% +0.05%
==========================================
Files 1548 1550 +2
Lines 106701 106946 +245
Branches 13309 13312 +3
==========================================
+ Hits 57699 57888 +189
- Misses 49002 49058 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43561: Size comparison from 2c98999 to bf31d71 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
soares-sergio
approved these changes
Mar 13, 2026
|
PR #43561: Size comparison from 2c98999 to a5cdb9f Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Pw read write access for more code driven clusters -
Testing
Testing in CI for now, will be tested in postsubmit.