Skip to content

[Chef] Enable Pw access for more attributes #43561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sxb427 wants to merge 4 commits into
base: master
Choose a base branch
from
+147 −1
Open

[Chef] Enable Pw access for more attributes #43561

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
765b398
Enable Pw access for more attributes
sxb427 Mar 11, 2026
93b61b3
Merge branch 'project-chip:master' into fake-attribute-access
sxb427 Mar 11, 2026
bf31d71
Gemini comments
sxb427 Mar 12, 2026
a5cdb9f
Fix compile issue
sxb427 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 163 additions & 1 deletion examples/chef/common/FakeAttributeAccess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@
#include <app/clusters/valve-configuration-and-control-server/CodegenIntegration.h>
#endif

#if MATTER_DM_ILLUMINANCE_MEASUREMENT_CLUSTER_SERVER_ENDPOINT_COUNT > 0
#include <app/clusters/illuminance-measurement-server/CodegenIntegration.h>
#endif

#if MATTER_DM_OCCUPANCY_SENSING_CLUSTER_SERVER_ENDPOINT_COUNT > 0
#include <app/clusters/occupancy-sensor-server/CodegenIntegration.h>
#endif

namespace chip {
namespace app {
namespace Clusters {
Expand Down Expand Up @@ -83,6 +91,54 @@ class AttributeAccessor : public chip::rpc::PigweedDebugAccessInterceptor
}
return ::pw::OkStatus();
}
case TemperatureMeasurement::Attributes::MinMeasuredValue::Id: {
DataModel::Nullable<int16_t> minMeasuredValue;
CHIP_ERROR err = decoder.Decode(minMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode minMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

auto temperatureMeasurement = TemperatureMeasurement::FindClusterOnEndpoint(path.mEndpointId);
if (temperatureMeasurement == nullptr)
{
return ::pw::Status::Internal();
}

err = TemperatureMeasurement::SetMeasuredValueRange(path.mEndpointId, minMeasuredValue,
temperatureMeasurement->GetMaxMeasuredValue());
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to set minMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}
return ::pw::OkStatus();
}
case TemperatureMeasurement::Attributes::MaxMeasuredValue::Id: {
DataModel::Nullable<int16_t> maxMeasuredValue;
CHIP_ERROR err = decoder.Decode(maxMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode maxMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

auto temperatureMeasurement = TemperatureMeasurement::FindClusterOnEndpoint(path.mEndpointId);
if (temperatureMeasurement == nullptr)
{
return ::pw::Status::Internal();
}

err = TemperatureMeasurement::SetMeasuredValueRange(path.mEndpointId, temperatureMeasurement->GetMinMeasuredValue(),
maxMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to set maxMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}
return ::pw::OkStatus();
}
}
#endif // MATTER_DM_TEMPERATURE_MEASUREMENT_CLUSTER_SERVER_ENDPOINT_COUNT > 0
#if MATTER_DM_VALVE_CONFIGURATION_AND_CONTROL_CLUSTER_SERVER_ENDPOINT_COUNT > 0
Expand All @@ -106,7 +162,113 @@ class AttributeAccessor : public chip::rpc::PigweedDebugAccessInterceptor
ChipLogProgress(Zcl, "[Pw] Successfully set current level to " ChipLogFormatMEI ".", ChipLogValueMEI(level));
return ::pw::OkStatus();
}
#endif
#endif // MATTER_DM_VALVE_CONFIGURATION_AND_CONTROL_CLUSTER_SERVER_ENDPOINT_COUNT > 0
#if MATTER_DM_ILLUMINANCE_MEASUREMENT_CLUSTER_SERVER_ENDPOINT_COUNT > 0
case IlluminanceMeasurement::Id:
switch (path.mAttributeId)
{
case IlluminanceMeasurement::Attributes::MeasuredValue::Id: {
DataModel::Nullable<uint16_t> measuredValue;
CHIP_ERROR err = decoder.Decode(measuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode measuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

err = IlluminanceMeasurement::SetMeasuredValue(path.mEndpointId, measuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to set measuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

if (measuredValue.IsNull())
{
ChipLogProgress(Zcl, "[Pw] Successfully set measuredValue to null.");
}
else
{
ChipLogProgress(Zcl, "[Pw] Successfully set measuredValue to %u.", measuredValue.Value());
}
return ::pw::OkStatus();
}
case IlluminanceMeasurement::Attributes::MinMeasuredValue::Id: {
DataModel::Nullable<uint16_t> minMeasuredValue;
CHIP_ERROR err = decoder.Decode(minMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode minMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

auto illuminanceMeasurement = IlluminanceMeasurement::FindClusterOnEndpoint(path.mEndpointId);
if (illuminanceMeasurement == nullptr)
{
return ::pw::Status::Internal();
}

err = IlluminanceMeasurement::SetMeasuredValueRange(path.mEndpointId, minMeasuredValue,
illuminanceMeasurement->GetMaxMeasuredValue());
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to set minMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}
return ::pw::OkStatus();
}
case IlluminanceMeasurement::Attributes::MaxMeasuredValue::Id: {
DataModel::Nullable<uint16_t> maxMeasuredValue;
CHIP_ERROR err = decoder.Decode(maxMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode maxMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

auto illuminanceMeasurement = IlluminanceMeasurement::FindClusterOnEndpoint(path.mEndpointId);
if (illuminanceMeasurement == nullptr)
{
return ::pw::Status::Internal();
}

err = IlluminanceMeasurement::SetMeasuredValueRange(path.mEndpointId, illuminanceMeasurement->GetMinMeasuredValue(),
maxMeasuredValue);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to set maxMeasuredValue: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}
return ::pw::OkStatus();
}
}
#endif // MATTER_DM_ILLUMINANCE_MEASUREMENT_CLUSTER_SERVER_ENDPOINT_COUNT > 0
#if MATTER_DM_OCCUPANCY_SENSING_CLUSTER_SERVER_ENDPOINT_COUNT > 0
case OccupancySensing::Id:
switch (path.mAttributeId)
{
case OccupancySensing::Attributes::Occupancy::Id: {
BitMask<OccupancySensing::OccupancyBitmap> occupancy;
CHIP_ERROR err = decoder.Decode(occupancy);
if (err != CHIP_NO_ERROR)
{
ChipLogError(Zcl, "[Pw] Failed to decode occupancy: %" CHIP_ERROR_FORMAT, err.Format());
return ::pw::Status::Internal();
}

auto occupancySensing = OccupancySensing::FindClusterOnEndpoint(path.mEndpointId);
if (occupancySensing == nullptr)
{
return ::pw::Status::Internal();
}

occupancySensing->SetOccupancy(occupancy.Has(OccupancySensing::OccupancyBitmap::kOccupied));
ChipLogProgress(Zcl, "[Pw] Successfully set occupancy to %d.",
occupancy.Has(OccupancySensing::OccupancyBitmap::kOccupied));
return ::pw::OkStatus();
}
}
#endif // MATTER_DM_OCCUPANCY_SENSING_CLUSTER_SERVER_ENDPOINT_COUNT > 0
}
return std::nullopt;
}
Expand Down
Loading