fix(generaldiagnostics): Fix homeassistant commissioning of light_eth #376
fix(generaldiagnostics): Fix homeassistant commissioning of light_eth #376thouters wants to merge 1 commit intoproject-chip:mainfrom
Conversation
|
|
Summary of ChangesHello @thouters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing the successful commissioning of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly changes the error code from InvalidAction to ConstraintError when an out-of-bounds index is requested for the network_interfaces attribute list. This aligns with the Matter specification, which mandates a CONSTRAINT_ERROR for such cases. I have one minor suggestion to remove a now-obsolete TODO comment.
thouters
force-pushed
the
mr/fix-ha-commissioning
branch
from
26f7a1b to
60f3b1a
Compare
Fix light_eth example of rs-matter-stack. fn network_interfaces() gets called with ArrayAttributeRead::ReadOne index beyond the length of the interfaces present. Return a ConstraintError when no netif was matched. The change fixes this error message which aborts the commissioning process: rs_matter::respond] Responder: Handler 0 / exchange 7::1: Abandoned because of error Error::InvalidAction
thouters
force-pushed
the
mr/fix-ha-commissioning
branch
from
60f3b1a to
7aaea66
Compare
|
PR #376: Size comparison from d502046 to 7aaea66 Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
thouters
changed the title
|
@thouters please run |
Subject says it all - apply a `cargo fmt` to PR #376. --------- Co-authored-by: Thomas Langewouters <thomas.langewouters@thouters.be>
|
See #377 |
4 participants
Fix light_eth example of rs-matter-stack.
fn network_interfaces() gets called with
ArrayAttributeRead::ReadOne index beyond the length of the interfaces present.
Return a ConstraintError when no netif was matched.
The change fixes this error message which aborts the commissioning process:
rs_matter::respond] Responder: Handler 0 / exchange 7::1: Abandoned because of error Error::InvalidAction