Conversation
Fix light_eth example of rs-matter-stack. fn network_interfaces() gets called with ArrayAttributeRead::ReadOne index beyond the length of the interfaces present. Return a ConstraintError when no netif was matched. The change fixes this error message which aborts the commissioning process: rs_matter::respond] Responder: Handler 0 / exchange 7::1: Abandoned because of error Error::InvalidAction
Summary of ChangesHello @ivmarkov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, while titled as a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, titled as a formatting change, also modifies an error code. While the formatting is fine, the new error code ConstraintError is not the most appropriate for the situation. According to the Matter specification, when trying to access a list element at an index that doesn't exist, UNSUPPORTED_ACCESS should be returned. I've added a comment to suggest using the correct error code.
|
Merging because PR #376 was already approved. It just needs formatting. |
|
PR #377: Size comparison from d502046 to 44f3e13 Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
2 participants
Subject says it all - apply a
cargo fmtto PR #376.