Open
Conversation
Signed-off-by: Kamesh Sampath <kamesh.sampath@hotmail.com>
This was referenced Mar 5, 2018
Author
|
@jcrossley3 - I still need to add the APIManagement job, wondering shall I add to the same template? |
Member
|
@kameshsampath sure that's fine |
jcrossley3
requested changes
Mar 5, 2018
Member
jcrossley3
left a comment
jcrossley3
left a comment
There was a problem hiding this comment.
Should this go in the ephemeral template, too?
| metadata: | ||
| name: apigateway | ||
| data: | ||
| apimgmt-init: | |
Member
There was a problem hiding this comment.
This script isn't referenced by anything. Can we get rid of it? If not, let's remove the redundancy and factor the common stuff into a shared script
| apigateway-init: | | ||
| # Dynamically determine API gateway host and other environment variables | ||
| export TOKEN="$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" | ||
| export NAMESPACE="$(cat /run/secrets/kubernetes.io/serviceaccount/namespace)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving API Gateway related changes from Original Repo to this new repo
Signed-off-by: Kamesh Sampath kamesh.sampath@hotmail.com