Add --compat-disk-labels option#256
Open
deajan wants to merge 2 commits intoprometheus-community:masterfrom
Open
Add --compat-disk-labels option#256deajan wants to merge 2 commits intoprometheus-community:masterfrom
deajan wants to merge 2 commits intoprometheus-community:masterfrom
Conversation
Signed-off-by: Orsiris de Jong <ozy@netpower.fr>
Signed-off-by: Orsiris de Jong <ozy@netpower.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a difference in metrics between
smartmon.shandsmartmon.py:became
So basically the metric name changed, and the labels changed too which makes parsing / relabeling a pain.
So my proposition is to add --compat-disk-labels to smartmon.py in order for the latter to generate metrics with the same disk name as previously found in smarmon.sh.
The
--compat-disk-labelsparameter has to be applied explicitly, so no behavior changes for existing setups.