Skip to content

Conversation

@matteobettini
Copy link
Member

@matteobettini matteobettini commented Apr 22, 2025

The idea is that (assuming the action = y and u_shoot_multiuplier =0.6, default)

y + 0.6 = y * 2.67 * 0.6

fixes #155

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (4a5b53e) to head (a8e8766).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vmas/scenarios/football.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          93       93           
  Lines       10462    10462           
=======================================
  Hits         9116     9116           
  Misses       1346     1346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matteobettini matteobettini merged commit ac30957 into main Apr 23, 2025
4 checks passed
@matteobettini matteobettini deleted the football-fix branch April 23, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent name or operation for shoot_multiplier in football

2 participants