Fix package version updates not appearing on Discord notifications #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like in package publication we should check the validity of the webhook as an object, rather than specific fields as a string, when we don't expect them to be a string
Member
Author
|
With this change already being in production, and having sat here with some time for a review, I'll go ahead and merge it to allow the codebase to accurately reflect what's being used publicly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the package version publications not appearing on Discord.
Seems the issue stems from overly restrictive validity checks before the webhook ever even ran.
Which also has the unfortunate side effect of feature detection not updating on a per version basis like we would expect.
But this PR loosens those checks opting to instead check the same exact way we do on package publication, and letting the individual functions we call deal with the specific validity.
Having already tested this in production we can now be confident this PR fixes the issue. And like I've mentioned these changes are already in production, this PR serves more as an post-approval, just to ensure there's some transparency about what I've changed.