SDKv2 Diff tests for Map #2830
Merged
SDKv2 Diff tests for Map #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 14, 2025
Closed
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
from
f04108e to
f2a0c1c
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
8552a4a to
3a114ca
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
from
61c04a4 to
631abf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 325 325
Lines 41621 41621
=======================================
+ Hits 28093 28095 +2
+ Misses 11951 11948 -3
- Partials 1577 1578 +1 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
3a114ca to
82a72f1
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
2 times, most recently
from
727543c to
9eee6e7
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
02d131f to
8789663
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
3 times, most recently
from
18d35fd to
7a1756c
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
8789663 to
ec47d3c
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
from
7a1756c to
0a48b67
Compare
iwahbe
reviewed
Jan 15, 2025
Member
iwahbe
left a comment
iwahbe
left a comment
There was a problem hiding this comment.
I have the same response as the previous PR. Can we refactor the test block into it's own function? Duplicate (or worse - almost duplicate) code is very hard to maintain.
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
ec47d3c to
6058e94
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
2 times, most recently
from
2dd1741 to
86c44b9
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_test_map
branch
from
86c44b9 to
379450d
Compare
iwahbe
approved these changes
Jan 15, 2025
Contributor
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the coverage of the SDKv2 bridge for Diff for Map types.
f2a0c1c contains the test recordings
fixes #2787