-
Notifications
You must be signed in to change notification settings - Fork 50
Refactor sdkv2 detailed diff tests #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VenelinMartinov
merged 2 commits into
master
from
vvm/refactor_sdkv2_detailed_diff_tests
Jan 14, 2025
Merged
Refactor sdkv2 detailed diff tests #2816
VenelinMartinov
merged 2 commits into
master
from
vvm/refactor_sdkv2_detailed_diff_tests
Jan 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jan 7, 2025
Closed
674db1c to
4f6a39f
Compare
817019b to
2c18440
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2816 +/- ##
=======================================
Coverage 68.70% 68.70%
=======================================
Files 325 325
Lines 41621 41621
=======================================
Hits 28595 28595
Misses 11419 11419
Partials 1607 1607 ☔ View full report in Codecov by Sentry. |
dbc1c2d to
8afea58
Compare
2c18440 to
d36b425
Compare
8afea58 to
acc0f73
Compare
d36b425 to
4da1a4c
Compare
acc0f73 to
7aadd5d
Compare
4da1a4c to
bc0f627
Compare
7aadd5d to
06d6bb1
Compare
bc0f627 to
a738145
Compare
iwahbe
approved these changes
Jan 14, 2025
Base automatically changed from
vvm/refactor_pf_detailed_diff_tests
to
master
January 14, 2025 11:23
a738145 to
98c3684
Compare
Contributor
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the SDKv2 detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large. Very similar to what #2814 does for PF.
This PR:
TestDetailedDiffSetinto a few separate tests. This will allow the tests to be run on different shards.value_makers.gofile, instead of duplicating in each test.2c18440 has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.