SDKv2 Diff tests for primitive types #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 14, 2025
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2829 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 325 325
Lines 41621 41621
=======================================
Hits 28092 28092
Misses 11950 11950
Partials 1579 1579 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
ecbef29 to
62ee451
Compare
VenelinMartinov
force-pushed
the
vvm/test_sharding
branch
from
3b7968c to
fa4a969
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
2 times, most recently
from
3a114ca to
82a72f1
Compare
VenelinMartinov
force-pushed
the
vvm/test_sharding
branch
3 times, most recently
from
a541316 to
ae81692
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
2 times, most recently
from
8789663 to
ec47d3c
Compare
iwahbe
approved these changes
Jan 15, 2025
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_primitive
branch
from
ec47d3c to
6058e94
Compare
VenelinMartinov
added a commit
that referenced
this pull request
Jan 17, 2025
This PR refactors the Set and List Diff tests to use the generic diff utility functions and types introduced in #2829. This should make the tests more maintainable and more in-line with what other tests do. [861ec1f](861ec1f) contains the changes: - Refactors the tests to use the generic `diffSchemaValueMakerPair` and `diffScenario` types for their tests. - Refactors the tests to use `prop` for top-level properties and `nested_prop` for nested ones, like the rest of the tests. - Refactors the tests to use the generic `runSDKv2TestMatrix` test function. - Refactors the `valueMaker` functions from `value_makers.go` to return a `map[string]cty.Value ` instead of a `cty.Value` which needs to be transformed further after. - Corrects three tests in `list element removed`, where the order of the elements was wrong in the changed values. [f800d2d](f800d2d) contains the test recordings. Related to #2788 Related to #2789
Contributor
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the test coverage for primitive types (string, bool, int and float) for the SDKv2 bridge for Diff. 14807c6 and 8552a4a contain the test recordings.
fixes #2786