-
Notifications
You must be signed in to change notification settings - Fork 50
Move PF detailed diff test to separate folder #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2813 +/- ##
=======================================
Coverage 68.66% 68.67%
=======================================
Files 325 325
Lines 41579 41579
=======================================
+ Hits 28551 28553 +2
+ Misses 11423 11420 -3
- Partials 1605 1606 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 7, 2025
Closed
iwahbe
approved these changes
Jan 8, 2025
t0yv0
approved these changes
Jan 10, 2025
814b7b9 to
13d6e52
Compare
0e4fc2e to
d538ddb
Compare
13d6e52 to
64c6d07
Compare
d538ddb to
3e69b03
Compare
Base automatically changed from
vvm/remove_redundant_bridged_provider_util
to
master
January 13, 2025 15:30
3e69b03 to
89867cb
Compare
This was referenced Jan 14, 2025
Contributor
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the PF detailed diff tests to a separate folder. This should make it easier to reuse some code between them without exposing it to the other tests in the folder. No other changes in this PR.