Required properties with default will now project as optional for SDKv1 providers #3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced May 29, 2025
VenelinMartinov
force-pushed
the
vvm/clean_up_unnecessary_shim_interfaces
branch
from
11f23c8 to
ba5a08d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
==========================================
- Coverage 68.74% 68.68% -0.06%
==========================================
Files 336 336
Lines 43610 43645 +35
==========================================
- Hits 29979 29978 -1
- Misses 11920 11957 +37
+ Partials 1711 1710 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VenelinMartinov
force-pushed
the
vvm/refactor_shim_internal
branch
from
d0ef58b to
5fa7b74
Compare
VenelinMartinov
force-pushed
the
vvm/clean_up_unnecessary_shim_interfaces
branch
from
ba5a08d to
6259947
Compare
t0yv0
reviewed
May 29, 2025
| return s.tf.DefaultValue() | ||
| } | ||
|
|
||
| func (s v1Schema) HasDefault() bool { |
Member
There was a problem hiding this comment.
This is a behavior change for SDK-v1 providers right? Perhaps worth calling out? Or am I missing something?
Contributor
Author
There was a problem hiding this comment.
Yeah, fair.
t0yv0
reviewed
May 29, 2025
pkg/pf/proto/attribute.go
Outdated
|
|
||
| func (a attribute) SetHash(v interface{}) int { panic("UNIMPLIMENTED") } | ||
| func (a attribute) SetHash(v interface{}) int { panic("UNIMPLIMENTED") } | ||
| func (a attribute) SetElementHash(v interface{}) (int, error) { panic("UNIMPLIMENTED") } |
Member
There was a problem hiding this comment.
How do we know this is not getting called? Perhaps a quick comment?
t0yv0
approved these changes
May 29, 2025
t0yv0
changed the title
VenelinMartinov
force-pushed
the
vvm/clean_up_unnecessary_shim_interfaces
branch
from
8d6a25c to
f6dce5d
Compare
Contributor
|
This PR has been shipped in release v3.110.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor.Now that adding methods to theshiminterfaces is no longer breaking we can remove some of the unnecessary interface clutter.The only effective change here is that the SDKv1 now implements
HasDefault, which means #3035 will apply to it as well. This is unlikely to have a meaningful impact.