Fix PF dynamic type diff error #3098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
- Coverage 68.80% 68.78% -0.03%
==========================================
Files 335 335
Lines 43560 43560
==========================================
- Hits 29971 29962 -9
- Misses 11877 11887 +10
+ Partials 1712 1711 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VenelinMartinov
force-pushed
the
vvm/pf_dynamic_diff_err
branch
from
ed7bd76 to
23a824c
Compare
VenelinMartinov
force-pushed
the
vvm/pf_dynamic_diff_err
branch
from
8a2ff40 to
0939cb1
Compare
This was referenced May 29, 2025
t0yv0
reviewed
May 29, 2025
| if err != nil { | ||
| return nil, fmt.Errorf("[pf/tfbridge] Error calling EncodePropertyMap: %w", err) | ||
| } | ||
| rawState, err := pfutils.NewRawState(tfType, value) |
t0yv0
approved these changes
May 29, 2025
Contributor
|
This PR has been shipped in release v3.109.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2945 we accidentally changed the behaviour for providers where RawStateDeltas were not enabled. After 2945 we would unconditionally produce the JSON serialization of the state even if it isn't used.
It is only used for upgrading state and for RawStateDeltas. The unintended effect here is that we exposed #3078 to all users of attributes of DynamicType even if no upgrades or RawStateDeltas are used.
This PR changes that to not produce the JSON serialization if not necessary. I've also added some tests for both the behaviour fixed here and the behaviour which needs #3078
fixes #3095