Skip to content

Report partial errors #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Report partial errors #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions pkg/modprovider/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,15 +278,8 @@ func (h *moduleHandler) applyModuleOperation(
}

if applyErr != nil {
// TODO[pulumi/pulumi-terraform-module#342] Possibly wrap partial errors in initializationError. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment suggests that there might be issues with Update here: #342 (comment)

Has this been addressed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we need to add some additional test cases around this since the current one only tests a create failure.

// does not quite work as expected yet as views get recorded into state as pending_operations. They
// need to be recorded as finalized operations because they did complete.
if 1+2 == 4 {
applyErr = h.initializationError(moduleOutputs, applyErr.Error())
}

// Instead, log and propagate the error for now. This will forget partial TF state but fail Pulumi.
logger.Log(ctx, tfsandbox.Error, fmt.Sprintf("partial failure in apply: %v", applyErr))
// we have a partial error, wrap it with ErrorResourceInitFailed
applyErr = h.initializationError(moduleOutputs, applyErr.Error())
}

return moduleOutputs, views, applyErr
Expand Down
2 changes: 0 additions & 2 deletions tests/acc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ func TestLambdaMemorySizeDiff(t *testing.T) {
func TestPartialApply(t *testing.T) {
t.Parallel()

t.Skip("TODO[pulumi/pulumi#19635]")

var debugOpts debug.LoggingOptions

// To enable debug logging in this test, un-comment:
Expand Down
Loading