Report partial errors #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeffryes
force-pushed
the
partial_errors
branch
from
29275e3 to
3b63a35
Compare
|
This change is part of the following stack: Change managed by git-spice. |
mjeffryes
force-pushed
the
fix_eks_test
branch
2 times, most recently
from
0a45dd3 to
dca1834
Compare
mjeffryes
force-pushed
the
partial_errors
branch
from
3b63a35 to
f09ca32
Compare
| } | ||
|
|
||
| if applyErr != nil { | ||
| // TODO[pulumi/pulumi-terraform-module#342] Possibly wrap partial errors in initializationError. This |
There was a problem hiding this comment.
This comment suggests that there might be issues with Update here: #342 (comment)
Has this been addressed?
There was a problem hiding this comment.
Yeah, I think we need to add some additional test cases around this since the current one only tests a create failure.
Zaid-Ajaj
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion in #342 (comment) to report partial errors. In my local testing this does seem to handle partial failures correctly on create and update.
fixes: #386
related: pulumi/pulumi#19635, #342 (We may need additional testing on delete and refresh before declaring these issues complete)