Skip to content

Conversation

@iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 14, 2025

This PR makes 3 changes file discovery:

  • It ignores directories called vendor, since that name is commonly used by go libraries to house other libraries.
  • It changes the default output to quote the search string -run "^(TestOne|TestTwo)$" ./somePackage instead of -run ^(TestOne|TestTwo)$ ./somePackage.
  • It excludes nested modules from test discovery.

While these changes are generically positive, they are motivated by pulumi/pulumi-terraform-bridge#2832.

@iwahbe iwahbe changed the title Iwahbe/fix string splats Quote output strings & skip the vendor directory Jan 14, 2025
@iwahbe iwahbe requested review from a team and VenelinMartinov January 14, 2025 15:52
@iwahbe iwahbe self-assigned this Jan 14, 2025
@iwahbe iwahbe marked this pull request as ready for review January 14, 2025 15:56
@iwahbe iwahbe merged commit 289b279 into main Jan 14, 2025
1 check passed
iwahbe added a commit that referenced this pull request Jan 15, 2025
After enabling tests in CI, I realized they weren't passing (due to #2). This fixes a
regression introduced in #2 and updates the tests to the intended changes from #2.
@iwahbe iwahbe mentioned this pull request Jan 15, 2025
iwahbe added a commit that referenced this pull request Jan 15, 2025
After enabling tests in CI, I realized they weren't passing (due to #2). This fixes a
regression introduced in #2 and updates the tests to the intended changes from #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants