Skip to content

Conversation

@bastelfreak
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@bastelfreak bastelfreak requested a review from a team as a code owner March 18, 2025 15:01
@bastelfreak
Copy link
Contributor Author

I think there's a bug in the CI config. The windows jobs seem to ignore the windows specific stuff in https://github.com/puppetlabs/puppet/blob/main/puppet.gemspec#L42

@rwaffen
Copy link

rwaffen commented May 19, 2025

I'm also interested in this change.

@bastelfreak bastelfreak force-pushed the minitar branch 2 times, most recently from 30fac78 to 0c9c42a Compare May 19, 2025 16:07
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 485d1aa into puppetlabs:main May 21, 2025
6 checks passed
@LukasAud LukasAud added the dependencies Pull requests that update a dependency file label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants