Update figure shortcodes to new syntax#283
Merged
agriyakhetarpal merged 10 commits intopybamm-team:mainfrom Dec 4, 2025
Merged
Update figure shortcodes to new syntax#283agriyakhetarpal merged 10 commits intopybamm-team:mainfrom
agriyakhetarpal merged 10 commits intopybamm-team:mainfrom
Conversation
❌ Deploy Preview for pybamm-developer-preview failed.
|
goanpeca
force-pushed
the
update/shortcodes
branch
from
8aa7b96 to
da2e3d6
Compare
Member
There was a problem hiding this comment.
Thanks for this, @goanpeca! I think there is one more change needed:
Start building sites …
hugo v0.141.0-e7bd51698e5c3778a86003018702b1a7dcb9559a+extended+withdeploy darwin/arm64 BuildDate=2025-01-16T13:11:18Z VendorInfo=hugo-python-distributions
Total in 52 ms
Error: error building site: process: readAndProcessContent: "/Users/agriyakhetarpal/Desktop/pybamm.org/content/publications.md:37:1": failed to extract shortcode: shortcode "button" does not evaluate .Inner or .InnerDeindent, yet a closing tag was provided
You may run it with nox locally after syncing the submodule to our work in my fork.
Most of the required changes should be around
pybamm.org/content/publications.md
Lines 34 to 38 in da2e3d6
{{ < button >}}s were missed.
Edit: ah, I see that you've only ported the figure shortcodes in this PR. Perhaps we should port the button and image shortcodes in the same PR as well (and elsewhere in other contemporary PRs too)?
goanpeca
force-pushed
the
update/shortcodes
branch
from
da2e3d6 to
64d1be6
Compare
Contributor
Author
|
@agriyakhetarpal it has been fixed and tested! |
agriyakhetarpal
approved these changes
May 29, 2025
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @goanpeca! All good now :D
❌ Deploy Preview for pybamm-developer-preview failed.
|
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
agriyakhetarpal
requested review from
Copilot
and removed request for
Copilot
Member
|
Thanks a lot, @goanpeca! This really helped with the theme update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team!
As part of figure, image and button shortcodes as being updated on this PR I created this PR to prepare the website for moving to the new syntax when a new version is released!
Pinging @agriyakhetarpal