Skip to content

Conversation

@NicolaCourtier
Copy link
Member

@NicolaCourtier NicolaCourtier commented Dec 15, 2025

Description

Remove the custom build process for PyBaMM simulations without an experimental protocol. The aim is to improve maintainability by always using the build process provided by PyBaMM's Simulation class.

Also, change batch_solve to solve_batch to align with other function names such as evaluate_batch. Deprecate some of the warning/error catches that no longer appear to be needed.

Fixes #783

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.77%. Comparing base (4628a65) to head (d99745a).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/pybamm/simulator.py 91.66% 4 Missing ⚠️
pybop/applications/ocp_methods.py 0.00% 3 Missing ⚠️
pybop/simulators/base_simulator.py 33.33% 2 Missing ⚠️
pybop/applications/base_method.py 0.00% 1 Missing ⚠️
pybop/pybamm/eis_simulator.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #857      +/-   ##
===========================================
+ Coverage    89.41%   90.77%   +1.35%     
===========================================
  Files           63       67       +4     
  Lines         4857     5169     +312     
===========================================
+ Hits          4343     4692     +349     
+ Misses         514      477      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strategy pattern for _pybamm_pipeline post #780

2 participants