Skip to content

Align PyBaMM simulation methods #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolaCourtier merged 6 commits into from
Jan 9, 2026

Merge branch 'develop' into align-simulation-methods

bb495b4
Select commit
Loading
Failed to load commit list.
Merged

Align PyBaMM simulation methods #857

Merge branch 'develop' into align-simulation-methods
bb495b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2026 in 0s

90.77% (+1.35%) compared to 4628a65

View this Pull Request on Codecov

90.77% (+1.35%) compared to 4628a65

Details

Codecov Report

❌ Patch coverage is 85.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.77%. Comparing base (4628a65) to head (bb495b4).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/pybamm/simulator.py 91.66% 4 Missing ⚠️
pybop/applications/ocp_methods.py 0.00% 3 Missing ⚠️
pybop/simulators/base_simulator.py 33.33% 2 Missing ⚠️
pybop/applications/base_method.py 0.00% 1 Missing ⚠️
pybop/pybamm/eis_simulator.py 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #857      +/-   ##
===========================================
+ Coverage    89.41%   90.77%   +1.35%     
===========================================
  Files           63       67       +4     
  Lines         4857     5169     +312     
===========================================
+ Hits          4343     4692     +349     
+ Misses         514      477      -37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov