EV3 fix display #320
Merged
EV3 fix display #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data that never changes should be declared as const to allow the compiler to optimize it better and to prevent accidental modifications.
Add a hack to disable and flush the I and D caches at in the startup code. Previously, when we were using the U-Boot Linux loader to load our firmware, U-Boot was doing this for us. But since we switched to a different loader in commit c24798f ("bricks/_common/arm_none_eabi.mk: ev3 uImage is not Linux"), it broke the display among other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch is 🧹 (doesn't fix anything)
Second patch fixes regression reported in pybricks/support#2256 (comment).