Skip to content

pbio/platform/ev3/exceptionhandler.S: Fix bug in panic handler #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

pbio/platform/ev3/exceptionhandler.S: Fix bug in panic handler #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pbio/platform/ev3/exceptionhandler.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ CommonPanicHandler:
@ NOTE: Assumes we never use User mode
Copy link
Member

@dlech dlech Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still true?

Copy link
Collaborator Author

@ArcaneNibble ArcaneNibble Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you have to do special handling for User mode, since you can't switch into it and switch back out.

and r0, #MASK_SR_MODE
mrs r1, cpsr
and r2, r1, #MASK_SR_MODE
bic r2, r1, #MASK_SR_MODE
orr r2, r0
msr cpsr, r2
mov r3, r13
Expand Down