Skip to content

pbdrv/uart: const correctness for write buffer arg #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

pbdrv/uart: const correctness for write buffer arg #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/pbio/drv/uart/uart_ev3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ struct _pbdrv_uart_dev_t {
/** The current position in read_buf. */
uint8_t read_pos;
/** The buffer passed to the write function. */
uint8_t *write_buf;
const uint8_t *write_buf;
/** The length of write_buf in bytes. */
uint8_t write_length;
/** The current position in write_buf. */
Expand Down Expand Up @@ -131,7 +131,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uin
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

static pbio_error_t pbdrv_uart_write_pru(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
static pbio_error_t pbdrv_uart_write_pru(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {

const pbdrv_uart_ev3_platform_data_t *pdata = uart->pdata;

Expand Down Expand Up @@ -178,7 +178,7 @@ static pbio_error_t pbdrv_uart_write_pru(pbio_os_state_t *state, pbdrv_uart_dev_
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

pbio_error_t pbdrv_uart_write_hw(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write_hw(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {

const pbdrv_uart_ev3_platform_data_t *pdata = uart->pdata;

Expand Down Expand Up @@ -240,7 +240,7 @@ pbio_error_t pbdrv_uart_write_hw(pbio_os_state_t *state, pbdrv_uart_dev_t *uart,
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {
const pbdrv_uart_ev3_platform_data_t *pdata = uart->pdata;

if (pdata->uart_kind == EV3_UART_HW) {
Expand Down
3 changes: 2 additions & 1 deletion lib/pbio/drv/uart/uart_ev3_pru.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <stdio.h>
#include <string.h>
#include <stdbool.h>
#include <stdint.h>

#include <errno.h>

Expand Down Expand Up @@ -481,7 +482,7 @@ int32_t pbdrv_uart_ev3_pru_get_break_state(uint8_t line) {
return 0;
}

int32_t pbdrv_uart_ev3_pru_write_bytes(uint8_t line, uint8_t *pdata, int32_t size) {
int32_t pbdrv_uart_ev3_pru_write_bytes(uint8_t line, const uint8_t *pdata, int32_t size) {
omapl_pru_suart_t *suart = &suartdevs[line];

if (suart->write_busy || size == 0) {
Expand Down
6 changes: 3 additions & 3 deletions lib/pbio/drv/uart/uart_ev3_pru.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ int pbdrv_uart_ev3_pru_load_firmware(uint8_t *firmware_data, uint32_t firmware_s
int pbdrv_uart_ev3_pru_activate(uint8_t line);

void pbdrv_uart_ev3_pru_handle_irq_data(uint8_t line);
void pbdrv_uart_ev3_pru_set_baudrate(uint8_t line, unsigned int baud);
void pbdrv_uart_ev3_pru_set_baudrate(uint8_t line, uint32_t baud);

int pbdrv_uart_ev3_pru_read_bytes(uint8_t line, unsigned char *pdata, int size);
int pbdrv_uart_ev3_pru_write_bytes(uint8_t line, unsigned char *pdata, int size);
int pbdrv_uart_ev3_pru_read_bytes(uint8_t line, uint8_t *pdata, int32_t size);
int pbdrv_uart_ev3_pru_write_bytes(uint8_t line, const uint8_t *pdata, int32_t size);
bool pbdrv_uart_ev3_pru_can_write(uint8_t line);

#endif // _INTERNAL_PBDRV_UART_EV3_PRU_H_
4 changes: 2 additions & 2 deletions lib/pbio/drv/uart/uart_stm32f0.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct _pbdrv_uart_dev_t {
uint8_t *rx_buf;
uint8_t rx_buf_size;
uint8_t rx_buf_index;
uint8_t *tx_buf;
const uint8_t *tx_buf;
uint8_t tx_buf_size;
uint8_t tx_buf_index;
pbio_os_timer_t rx_timer;
Expand Down Expand Up @@ -102,7 +102,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uin
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {

PBIO_OS_ASYNC_BEGIN(state);

Expand Down
4 changes: 2 additions & 2 deletions lib/pbio/drv/uart/uart_stm32f4_ll_irq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct _pbdrv_uart_dev_t {
/** The current position in read_buf. */
uint8_t read_pos;
/** The buffer of the ongoing write function. */
uint8_t *write_buf;
const uint8_t *write_buf;
/** The length of write_buf in bytes. */
uint8_t write_length;
/** The current position in write_buf. */
Expand Down Expand Up @@ -108,7 +108,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uin
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {

PBIO_OS_ASYNC_BEGIN(state);

Expand Down
2 changes: 1 addition & 1 deletion lib/pbio/drv/uart/uart_stm32l4_ll_dma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uin
PBIO_OS_ASYNC_END(PBIO_SUCCESS);
}

pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout) {

const pbdrv_uart_stm32l4_ll_dma_platform_data_t *pdata = uart->pdata;

Expand Down
2 changes: 1 addition & 1 deletion lib/pbio/include/pbdrv/uart.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart_dev,
*
* @return The error code.
*/
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout);
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart, const uint8_t *msg, uint8_t length, uint32_t timeout);

#else // PBDRV_CONFIG_UART

Expand Down
4 changes: 2 additions & 2 deletions lib/pbio/test/src/test_lump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ struct _pbdrv_uart_dev_t {
uint8_t *rx_msg;
uint8_t rx_msg_length;
pbio_error_t rx_msg_result;
uint8_t *tx_msg;
const uint8_t *tx_msg;
pbio_os_timer_t tx_timer;
uint8_t tx_msg_length;
pbio_error_t tx_msg_result;
Expand Down Expand Up @@ -1134,7 +1134,7 @@ pbio_error_t pbdrv_uart_read(pbio_os_state_t *state, pbdrv_uart_dev_t *uart_dev,
PBIO_OS_ASYNC_END(uart_dev->rx_msg_result);
}

pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart_dev, uint8_t *msg, uint8_t length, uint32_t timeout) {
pbio_error_t pbdrv_uart_write(pbio_os_state_t *state, pbdrv_uart_dev_t *uart_dev, const uint8_t *msg, uint8_t length, uint32_t timeout) {

PBIO_OS_ASYNC_BEGIN(state);

Expand Down