Fix deepcopy signature on ABCs #13798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @abc.abstractmethod | ||
| def __deepcopy__(self) -> DHPublicKey: | ||
| def __deepcopy__(self, memodict: dict) -> DHPublicKey: |
Contributor
There was a problem hiding this comment.
Why memodict and not memo, like in the Python docs for object.__deepcopy__(self, memo)? Also note the same name was also used in docs/hazmat/primitives/asymmetric/cloudhsm.rst which is not touched in this PR.
Member
Author
There was a problem hiding this comment.
🙃 I copied from cloudhsm, which is why this matches. Using the same name as python upstrema makes sense.
joakimnordling
approved these changes
Nov 3, 2025
Contributor
joakimnordling
left a comment
joakimnordling
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
reaperhulk
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.