Skip to content

Fix deepcopy signature on ABCs #13798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reaperhulk merged 2 commits into from
Nov 3, 2025
Merged

Fix deepcopy signature on ABCs #13798

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4f08f
Fix deepcopy signature on ABCs
alex Nov 3, 2025
473b626
Use a name that matches python itself
alex Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/dh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __copy__(self) -> DHPublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> DHPublicKey:
def __deepcopy__(self, memodict: dict) -> DHPublicKey:
Copy link
Contributor

@joakimnordling joakimnordling Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why memodict and not memo, like in the Python docs for object.__deepcopy__(self, memo)? Also note the same name was also used in docs/hazmat/primitives/asymmetric/cloudhsm.rst which is not touched in this PR.

Copy link
Member Author

@alex alex Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 I copied from cloudhsm, which is why this matches. Using the same name as python upstrema makes sense.

"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -149,7 +149,7 @@ def __copy__(self) -> DHPrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> DHPrivateKey:
def __deepcopy__(self, memodict: dict) -> DHPrivateKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/dsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __copy__(self) -> DSAPrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> DSAPrivateKey:
def __deepcopy__(self, memodict: dict) -> DSAPrivateKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -149,7 +149,7 @@ def __copy__(self) -> DSAPublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> DSAPublicKey:
def __deepcopy__(self, memodict: dict) -> DSAPublicKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/ec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def __copy__(self) -> EllipticCurvePrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> EllipticCurvePrivateKey:
def __deepcopy__(self, memodict: dict) -> EllipticCurvePrivateKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -214,7 +214,7 @@ def __copy__(self) -> EllipticCurvePublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> EllipticCurvePublicKey:
def __deepcopy__(self, memodict: dict) -> EllipticCurvePublicKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/ed25519.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __copy__(self) -> Ed25519PublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> Ed25519PublicKey:
def __deepcopy__(self, memodict: dict) -> Ed25519PublicKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -132,7 +132,7 @@ def __copy__(self) -> Ed25519PrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> Ed25519PrivateKey:
def __deepcopy__(self, memodict: dict) -> Ed25519PrivateKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/ed448.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __copy__(self) -> Ed448PublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> Ed448PublicKey:
def __deepcopy__(self, memodict: dict) -> Ed448PublicKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -133,7 +133,7 @@ def __copy__(self) -> Ed448PrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> Ed448PrivateKey:
def __deepcopy__(self, memodict: dict) -> Ed448PrivateKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/rsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __copy__(self) -> RSAPrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> RSAPrivateKey:
def __deepcopy__(self, memodict: dict) -> RSAPrivateKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -146,7 +146,7 @@ def __copy__(self) -> RSAPublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> RSAPublicKey:
def __deepcopy__(self, memodict: dict) -> RSAPublicKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/x25519.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __copy__(self) -> X25519PublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> X25519PublicKey:
def __deepcopy__(self, memodict: dict) -> X25519PublicKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -125,7 +125,7 @@ def __copy__(self) -> X25519PrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> X25519PrivateKey:
def __deepcopy__(self, memodict: dict) -> X25519PrivateKey:
"""
Returns a deep copy.
"""
Expand Down
4 changes: 2 additions & 2 deletions src/cryptography/hazmat/primitives/asymmetric/x448.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __copy__(self) -> X448PublicKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> X448PublicKey:
def __deepcopy__(self, memodict: dict) -> X448PublicKey:
"""
Returns a deep copy.
"""
Expand Down Expand Up @@ -127,7 +127,7 @@ def __copy__(self) -> X448PrivateKey:
"""

@abc.abstractmethod
def __deepcopy__(self) -> X448PrivateKey:
def __deepcopy__(self, memodict: dict) -> X448PrivateKey:
"""
Returns a deep copy.
"""
Expand Down
Loading