fix(dev): update the way it attach to the dev container#1192
Draft
mattwang44 wants to merge 3 commits intomasterfrom
Draft
fix(dev): update the way it attach to the dev container#1192mattwang44 wants to merge 3 commits intomasterfrom
mattwang44 wants to merge 3 commits intomasterfrom
Conversation
326ebb0 to
8482a01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 71.19% 71.16% -0.03%
==========================================
Files 84 84
Lines 3451 3451
==========================================
- Hits 2457 2456 -1
- Misses 994 995 +1 ☔ View full report in Codecov by Sentry. |
8482a01 to
7341b7d
Compare
Member
Author
|
still not working on windows, so it's converted to a draft |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
The current dev script is reported as not working on Windows and Linux.
Note that the author and reviewers of #1172 are all mac users.
What this PR does are:
todos