Replace asyncio to anyio
#3012
Open
Replace asyncio to anyio
#3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
DouweM
requested changes
Sep 26, 2025
Comment on lines
+115
to
+116
| def _enter_lock(self) -> anyio.Lock: | ||
| return anyio.Lock() |
There was a problem hiding this comment.
Suggested change
| def _enter_lock(self) -> anyio.Lock: | |
| return anyio.Lock() | |
| def _enter_lock(self) -> anyio.Lock: | |
| # We use a cached_property for this because it seems to work better with temporal... | |
| return anyio.Lock() |
| for i, c in enumerate(awaitables): | ||
| tg.start_soon(run_and_store, c, i) | ||
|
|
||
| return results |
|
|
||
| else: | ||
| # TODO(Marcelo): We need to replace this with `anyio.as_completed()` from | ||
| # https://github.com/agronholm/anyio/pull/890. |
There was a problem hiding this comment.
You intend to vendor that function right? Because I don't think we should wait until that's released and then bump the requirement all the way to the latest -- that'd be annoying for users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.