-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace asyncio
to anyio
#3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kludex
wants to merge
4
commits into
main
Choose a base branch
from
david-solve-it
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace asyncio
to anyio
#3012
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
from __future__ import annotations as _annotations | ||
|
||
from collections.abc import Awaitable | ||
from typing import TypeVar, cast | ||
|
||
import anyio | ||
|
||
T = TypeVar('T') | ||
|
||
|
||
async def gather(*awaitables: Awaitable[T]) -> list[T]: | ||
"""Run multiple awaitables concurrently using an AnyIO task group.""" | ||
# We initialize the list, so we can insert the results in the correct order. | ||
results: list[T] = cast(list[T], [None] * len(awaitables)) | ||
|
||
async def run_and_store(coro: Awaitable[T], index: int) -> None: | ||
results[index] = await coro | ||
|
||
async with anyio.create_task_group() as tg: | ||
for i, c in enumerate(awaitables): | ||
tg.start_soon(run_and_store, c, i) | ||
|
||
return results | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we return a tuple? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -4,10 +4,9 @@ | |||||||||||
import functools | ||||||||||||
import warnings | ||||||||||||
from abc import ABC, abstractmethod | ||||||||||||
from asyncio import Lock | ||||||||||||
from collections.abc import AsyncIterator, Awaitable, Callable, Sequence | ||||||||||||
from contextlib import AbstractAsyncContextManager, AsyncExitStack, asynccontextmanager | ||||||||||||
from dataclasses import field, replace | ||||||||||||
from dataclasses import replace | ||||||||||||
from datetime import timedelta | ||||||||||||
from pathlib import Path | ||||||||||||
from typing import Annotated, Any | ||||||||||||
|
@@ -105,14 +104,17 @@ class MCPServer(AbstractToolset[Any], ABC): | |||||||||||
|
||||||||||||
_id: str | None | ||||||||||||
|
||||||||||||
_enter_lock: Lock = field(compare=False) | ||||||||||||
_running_count: int | ||||||||||||
_exit_stack: AsyncExitStack | None | ||||||||||||
|
||||||||||||
_client: ClientSession | ||||||||||||
_read_stream: MemoryObjectReceiveStream[SessionMessage | Exception] | ||||||||||||
_write_stream: MemoryObjectSendStream[SessionMessage] | ||||||||||||
|
||||||||||||
@functools.cached_property | ||||||||||||
def _enter_lock(self) -> anyio.Lock: | ||||||||||||
return anyio.Lock() | ||||||||||||
Comment on lines
+115
to
+116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
|
||||||||||||
def __init__( | ||||||||||||
self, | ||||||||||||
tool_prefix: str | None = None, | ||||||||||||
|
@@ -144,7 +146,6 @@ def __init__( | |||||||||||
self.__post_init__() | ||||||||||||
|
||||||||||||
def __post_init__(self): | ||||||||||||
self._enter_lock = Lock() | ||||||||||||
self._running_count = 0 | ||||||||||||
self._exit_stack = None | ||||||||||||
|
||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You intend to vendor that function right? Because I don't think we should wait until that's released and then bump the requirement all the way to the latest -- that'd be annoying for users