Add environment markers to skip install of outlines dependancies on Intel Macs #3312
+35
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Nov 3, 2025
| outlines-mlxlm = ["pydantic-ai-slim[outlines-mlxlm]=={{ version }}"] | ||
| outlines-sglang = ["pydantic-ai-slim[outlines-sglang]=={{ version }}"] | ||
| outlines-vllm-offline = ["pydantic-ai-slim[outlines-vllm-offline]=={{ version }}"] | ||
| outlines-vllm-offline = ["pydantic-ai-slim[outlines-vllm-offline]=={{ version }} ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"] |
There was a problem hiding this comment.
Are you sure we need it here as well? I think having it just in the slim package would be enough.
| outlines-mlxlm = ["outlines[mlxlm]>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64')"] | ||
| outlines-sglang = ["outlines[sglang]>=1.0.0, <1.3.0", "pillow"] | ||
| outlines-vllm-offline = ["vllm; python_version < '3.12'", "outlines>=1.0.0, <1.3.0"] | ||
| outlines-vllm-offline = ["vllm; python_version < '3.12' and ((sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win'))", "torch; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "outlines>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"] |
There was a problem hiding this comment.
Just to verify: Is this necessary for all of them, not just mlxlm?
| outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0", "transformers>=4.0.0", "pillow"] | ||
| outlines-llamacpp = ["outlines[llamacpp]>=1.0.0, <1.3.0"] | ||
| outlines-mlxlm = ["outlines[mlxlm]>=1.0.0, <1.3.0"] | ||
| outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "transformers>=4.0.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "pillow", "torch; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"] |
There was a problem hiding this comment.
Should win be win32 considering https://docs.python.org/3/library/sys.html#sys.platform?
Would it be possible to state only the platform we don't support, rather than having to exhaustively list those we do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3311
Recent PR added some dependancies that don't have builds for Intel MacBooks, so as per suggestion by @DouweM I added environment markers to skip installation for problematic libraries on Intel Macs.