Skip to content

Add environment markers to skip install of outlines dependancies on Intel Macs #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −13
Open

Add environment markers to skip install of outlines dependancies on Intel Macs #3312

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cad730
Add environment markers to skip outlines install on Intel Macs
pcustic Nov 2, 2025
f7125b0
Use make sync to update uv.lock
pcustic Nov 3, 2025
863f131
Cleaned up pyproject.tomls
pcustic Nov 4, 2025
55768bf
Merge remote-tracking branch 'upstream/main' into fix-uv-issue-intel-mac
pcustic Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pydantic_ai_slim/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ groq = ["groq>=0.25.0"]
mistral = ["mistralai>=1.9.10"]
bedrock = ["boto3>=1.39.0"]
huggingface = ["huggingface-hub[inference]>=0.33.5"]
outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0", "transformers>=4.0.0", "pillow"]
outlines-llamacpp = ["outlines[llamacpp]>=1.0.0, <1.3.0"]
outlines-mlxlm = ["outlines[mlxlm]>=1.0.0, <1.3.0"]
outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "transformers>=4.0.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "pillow", "torch; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
Copy link
Collaborator

@DouweM DouweM Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should win be win32 considering https://docs.python.org/3/library/sys.html#sys.platform?

Would it be possible to state only the platform we don't support, rather than having to exhaustively list those we do?

Copy link
Author

@pcustic pcustic Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I changed it to list platforms that are not supported in 863f131

outlines-llamacpp = ["outlines[llamacpp]>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "torch; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
outlines-mlxlm = ["outlines[mlxlm]>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64')"]
outlines-sglang = ["outlines[sglang]>=1.0.0, <1.3.0", "pillow"]
outlines-vllm-offline = ["vllm; python_version < '3.12'", "outlines>=1.0.0, <1.3.0"]
outlines-vllm-offline = ["vllm; python_version < '3.12' and ((sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win'))", "torch; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')", "outlines>=1.0.0, <1.3.0 ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
Copy link
Collaborator

@DouweM DouweM Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify: Is this necessary for all of them, not just mlxlm?

Copy link
Author

@pcustic pcustic Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it is not necessary for outlines-llamacpp, others need to stay because multiple libs are problematic (mlxml, torch, ray)

# Tools
duckduckgo = ["ddgs>=9.0.0"]
tavily = ["tavily-python>=0.5.0"]
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ examples = ["pydantic-ai-examples=={{ version }}"]
a2a = ["fasta2a>=0.4.1"]
dbos = ["pydantic-ai-slim[dbos]=={{ version }}"]
prefect = ["pydantic-ai-slim[prefect]=={{ version }}"]
outlines-transformers = ["pydantic-ai-slim[outlines-transformers]=={{ version }}"]
outlines-llamacpp = ["pydantic-ai-slim[outlines-llamacpp]=={{ version }}"]
outlines-transformers = ["pydantic-ai-slim[outlines-transformers]=={{ version }} ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
outlines-llamacpp = ["pydantic-ai-slim[outlines-llamacpp]=={{ version }} ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
outlines-mlxlm = ["pydantic-ai-slim[outlines-mlxlm]=={{ version }}"]
outlines-sglang = ["pydantic-ai-slim[outlines-sglang]=={{ version }}"]
outlines-vllm-offline = ["pydantic-ai-slim[outlines-vllm-offline]=={{ version }}"]
outlines-vllm-offline = ["pydantic-ai-slim[outlines-vllm-offline]=={{ version }} ; (sys_platform == 'linux') or (sys_platform == 'darwin' and platform_machine == 'arm64') or (sys_platform == 'win')"]
Copy link
Collaborator

@DouweM DouweM Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need it here as well? I think having it just in the slim package would be enough.

Copy link
Author

@pcustic pcustic Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, removed in 863f131


[project.urls]
Homepage = "https://ai.pydantic.dev"
Expand Down
Loading