Support subclass inits for Url and MultiHostUrl
#1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1508 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Oct 29, 2024
Contributor
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
It would be good to have some tests here :)
sydney-runkle
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit fe73652.
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…c-core#1508) Original-commit-hash: fe73652
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
…c-core#1508) Original-commit-link: pydantic/pydantic-core@fe73652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with pydantic/pydantic#10721
This is admittedly less efficient perf wise, but the benefit in
pydanticis worth it at this point. Should fix for v2.11 re perf.