Fix: dataclass InitVars shouldn't be required on serialization
#1602
+54
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1602 will not alter performanceComparing Summary
|
sydney-runkle
commented
Jan 21, 2025
| ) | ||
|
|
||
| s = SchemaSerializer(schema) | ||
| assert s.to_python(Foo(x=1), warnings='error') == {'x': 1} |
There was a problem hiding this comment.
please can you add a test with just the Foo schema, and a test for Bar here.
There was a problem hiding this comment.
and can you add a test for Foo(x=1, init_var=2)
There was a problem hiding this comment.
please can you add a test with just the Foo schema, and a test for Bar here.
Not quite sure what you mean here - I wasn't able to repro the issue without the union.
There was a problem hiding this comment.
I still it's still worth adding tests for the simplest cases.
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…ydantic/pydantic-core#1602) Original-commit-hash: 261c7ab
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pydantic/pydantic#11264